Twenty Nineteen: Audio are lacking bottom margin

[PGeorgiev]

Audio in Twenty Nineteen are lacking a bottom margin

Posts that have audio: Cover block with background image is too close to the media.
Attached is a screenshot from Mozilla Firefox

[PGeorgiev]

Twenty Nineteen audi file without margin

[desrosj]

Hi @PGeorgiev,

Thanks for this ticket! I'm having a little bit of trouble understanding the issue as reported.

I've attached what I am seeing when using Twenty Nineteen and inserting an audio block followed by a cover block. There appears to be a proper margin between the two inherited from the .entry .entry-content > * CSS rule.

Is the suggestion that there should be less of a margin after an audio block? Based on the patch applying a -24px margin, I think that's the case. But I'm not sure that's right because every block has a margin-bottom of 32px.

[PGeorgiev]

Replying to desrosj:

Hi @PGeorgiev,

Thanks for this ticket! I'm having a little bit of trouble understanding the issue as reported.

I've attached what I am seeing when using Twenty Nineteen and inserting an audio block followed by a cover block. There appears to be a proper margin between the two inherited from the .entry .entry-content > * CSS rule.

Is the suggestion that there should be less of a margin after an audio block? Based on the patch applying a -24px margin, I think that's the case. But I'm not sure that's right because every block has a margin-bottom of 32px.

Thanks for your reply,

It's just that the space between the two blocks seemed really big to me and that's why I'm proposing to reduce it.

Sorry, this is my first ticket (maybe a second) and if you don't think it makes sense, you can close it of course.
Appreciate it!

[desrosj]

Thanks for clarifying! I understand now.

I think that the margin is correct. I took a second look, and the space is definitely larger than between other blocks. It seems there is a height or line-height somewhere for the <figure> or <audio> tags resulting in white space.

I think the right way forward is to figure that out rather than adjusting the margin.

[PGeorgiev]

figure.wp-block-audio

[PGeorgiev]

Added patch 53681.2

[PGeorgiev]

Hey @desrosj,
I apologize a lot for the delay here. I added a style that only applies to figure.wp-block-audio in this case will only apply to this block and we will not affect the styles of the others

I would be happy to share your feedback as this is my first ticket