Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#53681 new defect (bug)

Twenty Nineteen: Audio are lacking bottom margin

Reported by: pgeorgiev's profile PGeorgiev Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-testing needs-patch
Focuses: Cc:

Description

Audio in Twenty Nineteen are lacking a bottom margin

Posts that have audio: Cover block with background image is too close to the media.
Attached is a screenshot from Mozilla Firefox

Attachments (6)

twenty-nineteen-audio.png (570.5 KB) - added by PGeorgiev 3 years ago.
Twenty Nineteen audi file without margin
53681.diff (438 bytes) - added by PGeorgiev 3 years ago.
Screen Shot 2021-07-20 at 09.06.54.png (507.8 KB) - added by desrosj 3 years ago.
Screen Shot 2021-07-20 at 10.45.51.png (382.1 KB) - added by desrosj 3 years ago.
block-audio-patch.png (627.9 KB) - added by PGeorgiev 3 years ago.
figure.wp-block-audio
53681.2.diff (468 bytes) - added by PGeorgiev 3 years ago.
Added patch 53681.2

Change History (12)

@PGeorgiev
3 years ago

Twenty Nineteen audi file without margin

@PGeorgiev
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Summary changed from Audio in Twenty Nineteen are lacking bottom margin to Twenty Nineteen: Audio are lacking bottom margin

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 years ago

#3 follow-up: @desrosj
3 years ago

  • Keywords reporter-feedback added
  • Version trunk deleted

Hi @PGeorgiev,

Thanks for this ticket! I'm having a little bit of trouble understanding the issue as reported.

I've attached what I am seeing when using Twenty Nineteen and inserting an audio block followed by a cover block. There appears to be a proper margin between the two inherited from the .entry .entry-content > * CSS rule.

Is the suggestion that there should be less of a margin after an audio block? Based on the patch applying a -24px margin, I think that's the case. But I'm not sure that's right because every block has a margin-bottom of 32px.

#4 in reply to: ↑ 3 @PGeorgiev
3 years ago

Replying to desrosj:

Hi @PGeorgiev,

Thanks for this ticket! I'm having a little bit of trouble understanding the issue as reported.

I've attached what I am seeing when using Twenty Nineteen and inserting an audio block followed by a cover block. There appears to be a proper margin between the two inherited from the .entry .entry-content > * CSS rule.

Is the suggestion that there should be less of a margin after an audio block? Based on the patch applying a -24px margin, I think that's the case. But I'm not sure that's right because every block has a margin-bottom of 32px.

Thanks for your reply,

It's just that the space between the two blocks seemed really big to me and that's why I'm proposing to reduce it.

Sorry, this is my first ticket (maybe a second) and if you don't think it makes sense, you can close it of course.
Appreciate it!

Last edited 3 years ago by PGeorgiev (previous) (diff)

#5 @desrosj
3 years ago

  • Focuses ui removed
  • Keywords needs-testing needs-patch added; has-patch reporter-feedback removed

Thanks for clarifying! I understand now.

I think that the margin is correct. I took a second look, and the space is definitely larger than between other blocks. It seems there is a height or line-height somewhere for the <figure> or <audio> tags resulting in white space.

I think the right way forward is to figure that out rather than adjusting the margin.

@PGeorgiev
3 years ago

figure.wp-block-audio

@PGeorgiev
3 years ago

Added patch 53681.2

#6 @PGeorgiev
3 years ago

Hey @desrosj,
I apologize a lot for the delay here. I added a style that only applies to figure.wp-block-audio in this case will only apply to this block and we will not affect the styles of the others

I would be happy to share your feedback as this is my first ticket

Note: See TracTickets for help on using tickets.