Widget editor calls get_block_categories() with incorrect arg type

[Enchiridion]

Just updated to 5.8.0 and found a couple issues with the new block widget editor while fixing all the new deprecated filters related to blocks.

\wp-admin\widgets-form-blocks.php:55
sprintf( 'wp.blocks.setCategories( %s );', wp_json_encode( get_block_categories( 'widgets-editor' ) ) ),

\wp-includes\class-wp-customize-widgets.php:865
sprintf( 'wp.blocks.setCategories( %s );', wp_json_encode( get_block_categories( 'widgets-customizer' ) ) ),

In these two places, get_block_categories() is being passed a string instead of the required WP_Post or WP_Block_Editor_Context instance. The string is causing a fatal error due to the type hinting on my function for the block_categories_all filter.

[audrasjb]

Good catch. It looks like we should replace 'widgets-customizer' and 'widgets-editor' with $block_editor_context variable on both files.

Replaced 'widgets-customizer' and 'widgets-editor' with $block_editor context in get_block_categories() function calls

Trac ticket: https://core.trac.wordpress.org/ticket/53757

Just got errors related to this, thanks for the fix @pbearne!

[audrasjb]

​PR #1532 applies cleanly against trunk and fixes the issue on my side. Thanks for the PR!

Marking for commit consideration as this issue is clearly related to the widget editor and needs to be addressed in the next point release.

[SergeyBiryukov]

In 51700:

Widgets: Pass correct context to get_block_categories() calls.

The get_block_categories() function expects either a WP_Post or a WP_Block_Editor_Context instance as the context argument, not a string.

Follow-up to [50996], [50997].

Props Enchiridion, pbearne, audrasjb.
Fixes #53757.

[SergeyBiryukov]

Reopening for backporting to the 5.8 branch.

Thanks for the PR! Merged in https://core.trac.wordpress.org/changeset/51700.

[desrosj]

In 51711:

Widgets: Pass correct context to get_block_categories() calls.

The get_block_categories() function expects either a WP_Post or a WP_Block_Editor_Context instance as the context argument, not a string.

Follow-up to [50996], [50997].

Props Enchiridion, pbearne, audrasjb, SergeyBiryukov.
Merges [51700] to the 5.8 branch.
Fixes #53757.