Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#53929 closed defect (bug) (fixed)

Update whatwg-fetch version to match the one in Gutenberg

Reported by: hareesh-pillai's profile Hareesh Pillai Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: good-first-bug has-patch
Focuses: Cc:


Core currently has whatwg-fetch v3.0.0. Gutenberg has the latest version (v 3.6.2) in the package-lock.json file.

Attachments (1)

53929.diff (1.7 KB) - added by rsiddharth 3 years ago.
Bump whatwg-fetch to version 3.6.2

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Build/Test Tools
  • Milestone changed from Awaiting Review to 5.9

Introduced in [43719] / #45065.

#2 follow-up: @desrosj
3 years ago

  • Keywords good-first-bug added

Related #53078.

I was trying to recall the reason why I did not include this update in #53078, but it's not coming to mind. It may have been an oversight. WordPress no longer depends on this polyfill as of [50934].

Based on the release notes, it seems updating this should be straightforward and will bring the latest update of the library to anyone still utilizing it.

Just a note for the contributor creating a patch for this: the version of the script needs to bumped in wp-includes/script-loader.php as well. The package is compiled into a script registered under the wp-polyfill-fetch handle.

#3 in reply to: ↑ 2 @Hareesh Pillai
3 years ago

Thanks for sharing the details, @desrosj.

WordPress no longer depends on this polyfill as of [50934].

In addition to updating, should we also remove this script from loading by default? Perhaps we could open a new ticket for that.

#4 @desrosj
3 years ago

The script should continue to be registered so that plugins and themes can enqueue the script if desired, but it should no longer be enqueued anywhere in WordPress Core. If it is, then we should fix that as it's a bug.

3 years ago

Bump whatwg-fetch to version 3.6.2

#5 @rsiddharth
3 years ago

  • Keywords has-patch added; needs-patch removed

#6 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51692:

External Libraries: Update whatwg-fetch package to version 3.6.2.

This matches the version used in the Gutenberg project.

While WordPress core no longer depends on this polyfill as of [50934], this brings the latest updates of the library to anyone still utilizing it.

For a full list of changes in this update, see the whatwg-fetch GitHub:

Follow-up to [43719], [50934].

Props hareesh-pillai, rsiddharth, desrosj.
Fixes #53929.

Note: See TracTickets for help on using tickets.