WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 4 weeks ago

#54047 closed enhancement (fixed)

New Aplication Password Name placeholder should be change or removed

Reported by: seedsca Owned by: hellofromTonya
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.6
Component: Application Passwords Keywords: has-patch commit
Focuses: accessibility, ui-copy Cc:

Description

Seems that on the patch committed on Oct 23rd, 2020 the placeholder for the Application Password Name was changed from esc_attr_e( 'Name this connection…' ) to esc_attr_e( 'WordPress App on My Phone' ).

Are Application Passwords only intended to be used on a WordPress App on My Phone?

Attachments (3)

54047.diff (1.8 KB) - added by audrasjb 2 months ago.
Application Passwords: Use a more generic placeholder for the application password name field
54047.2.diff (1.7 KB) - added by seedsca 8 weeks ago.
Removing the placeholder text
#54047.patch (1.6 KB) - added by rehanali 4 weeks ago.
Removed Placeholder Attribute.

Download all attachments as: .zip

Change History (15)

#1 @audrasjb
2 months ago

  • Keywords needs-patch added
  • Version changed from 5.8 to 5.6

Hello,

I think the idea was to use it as an application name sample, but indeed I think it's too specific.

Maybe something like "My WordPress App" would work better.

#2 @audrasjb
2 months ago

  • Component changed from General to Application Passwords

@audrasjb
2 months ago

Application Passwords: Use a more generic placeholder for the application password name field

#3 @audrasjb
2 months ago

  • Focuses ui-copy added
  • Keywords has-patch added; needs-patch removed

#4 @seedsca
2 months ago

Thanks for the quick reply to this! I'm wondering why a placeholder is needed since none of the other input fields on the page use them. Specially considering the input field's label "New Application Password Name" is quite clear.

I am currently working on a plugin that connects different WordPress installs through the Application Password system, and I'm sure there are many different ways to use this feature that are not Apps.

Seems like restrictive wording for such a powerful and versatile tool.

@seedsca
8 weeks ago

Removing the placeholder text

#5 @audrasjb
8 weeks ago

  • Focuses accessibility added

It makes sense to me, so +1 for removing the placeholder entirely :)
Adding accessibility focus so the Accessibility team can weight on this proposal if needed.

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


7 weeks ago

#7 @joedolson
7 weeks ago

The only real benefit a placeholder offers is to provide guidance on what kind of input should go in a field. Given that vast variation in how this field can be used and the clear labeling already present in the label, I don't see any reason to keep this placeholder.

Discussed in the Accessibility team bug scrub & agreed on there.

#8 @joedolson
7 weeks ago

  • Milestone changed from Awaiting Review to 5.9

@rehanali
4 weeks ago

Removed Placeholder Attribute.

#9 @audrasjb
4 weeks ago

  • Keywords commit added

Thanks for refreshing the patch. Marking this for commit.

#10 @audrasjb
4 weeks ago

Hmm. It was already patched in 54047.2.diff 🙂

#11 @hellofromTonya
4 weeks ago

  • Owner set to hellofromTonya
  • Status changed from new to reviewing

#12 @hellofromTonya
4 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 51878:

App Passwords: Remove placeholder from the app password name input field.

In [49294, 49752], the placeholder attribute changed to "WordPress App on My Phone". This change causes confusion as the field can be used in a variety of ways and is not limited to a phone.

Given a label exists for each field and clearly identifies its purpose, this commit removes the placeholder attribute from the input field.

Follow-up to [49109], [49294], [49752].

Props seedsca, audrasjb, joedolson, rehanali.
Fixes #54047.

Note: See TracTickets for help on using tickets.