Cannot have `%s` in default string for `get_theme_mod`

[jqz]

If the default string passed to get_theme_mod() contains %s (or suchlike) it will be replaced with a URI. But if it contains %%s it will be left unchanged and not converted to %s (i.e. escaping does not work). There is no way to obtain a literal %s in the default string (other than by providing one's own implementation of the get_theme_mod function, which rather defeats the point).

This has been broken by ​https://github.com/WordPress/WordPress/commit/83edc2476242bebfbe050e3bbf0826cd27b3c8d4

[jqz]

A typical example would be a setting which allows a CSS length value, with a default like 100%. Previously we could provide 100%% as the $default to get_theme_mod(), knowing that the function's behaviour was consistent. Now we would need to test the WordPress version to determine if this bug is present. And as stated above, some scenarios can't now be catered for at all.

[dlh]

Hi @jqz, and thanks for the ticket!

I might be misunderstanding, but this sounds quite similar to the issue reported in #49421. Do you agree? If so, let's keep the discussion in that ticket.

[jqz]

Replying to dlh:

I might be misunderstanding, but this sounds quite similar to the issue reported in #49421. Do you agree? If so, let's keep the discussion in that ticket.

Apologies, it is the same issue. Double apologies for being lazy and not searching for existing issues (I kind of assumed it was a bit niche and wouldn't have been previously reported). Triple apologies for having completely forgotten I myself had already reported this!

[SergeyBiryukov]

Thanks for the follow-up!