Twenty Twenty-One: footer links lack closing span tag

[sabernhardt]

Footer navigation menus specify ​wrapping each menu item in a span tag, using the link_before and link_after arguments.

However, when the link_after value is emptied to ​reset any description markup, that also removes the closing tag within footer links.

[sabernhardt]

54209.patch​ simply checks whether the link_after value is (only) the closing span tag before setting it to empty.

Another approach might accommodate custom arguments, but this could take care of the standard footer menu argument.

[mukesh27]

I can't find this code in ​WordPress git repo

Replying to sabernhardt:

However, when the link_after value is emptied to ​reset any description markup, that also removes the closing tag within footer links.

[sabernhardt]

Sorry, I wanted to show the context of why that line was added, but then forgot to mention the twenty_twenty_one_add_menu_description_args function.

It's a bit lower in the file now, starting on ​line 89.

[SergeyBiryukov]

In 51881:

Twenty Twenty-One: Keep the closing </span> tag in footer links.

When the link_after value is emptied to reset any description markup, make sure not to remove the closing tag within footer links.

Follow-up to [49216].

Props sabernhardt, mukesh27.
Fixes #54209.