WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 5 weeks ago

#54300 closed enhancement (fixed)

Clarify that changes to default discussion settings don't have retroactive effect

Reported by: tobifjellner Owned by: audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Administration Keywords: good-first-bug has-patch commit
Focuses: ui-copy Cc:

Description

Two improvements can be made to

https://build.trac.wordpress.org/browser/trunk/wp-admin/options-discussion.php?marks=61#L61

  1. It would be good if the message "These settings may be overridden for individual posts." gets changed so that it indicates that any change to these settings will only have effect on newly created pages and posts and won't change things retroactively. Suggested text: "The discussion settings are handled separately for every post and page. The current settings on this page are used for newly created posts and pages."
  1. The parenthesis would better be included in the string, this will generate a more natural text layout flow for RTL languages.

Attachments (5)

54300.diff (837 bytes) - added by sabbirshouvo 6 weeks ago.
I think this will be miniman and better version on proposed description. These settings may be overridden for individual posts & will be applied for newly created posts only.
54300.1.diff (830 bytes) - added by audrasjb 6 weeks ago.
Administration: Clarify that discussion settings will only be applied to new posts
54300.2.diff (831 bytes) - added by audrasjb 6 weeks ago.
Administration: Clarify that discussion settings will only be applied to new posts.
54300.3.diff (676 bytes) - added by johnjamesjacoby 5 weeks ago.
jjj-on-2021-11-02-at-11-19-56@2x.png (216.7 KB) - added by johnjamesjacoby 5 weeks ago.

Download all attachments as: .zip

Change History (19)

@sabbirshouvo
6 weeks ago

I think this will be miniman and better version on proposed description. These settings may be overridden for individual posts & will be applied for newly created posts only.

This ticket was mentioned in Slack in #core by tobifjellner. View the logs.


6 weeks ago

#2 @audrasjb
6 weeks ago

  • Milestone changed from Awaiting Review to 5.9

Moving for 5.9 consideration

#3 @audrasjb
6 weeks ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

@audrasjb
6 weeks ago

Administration: Clarify that discussion settings will only be applied to new posts

#4 @audrasjb
6 weeks ago

  • Focuses ui-copy added
  • Keywords has-patch added

In 54300.1.diff I removed entirely the parenthesis and I rephrased the previously proposed sentence to: "These settings may be overridden for individual posts and changes will be applied for newly created posts only."

#5 @audrasjb
6 weeks ago

@tobifjellner what do you think of this proposal?

#6 @tobifjellner
6 weeks ago

I think your proposal is good, @audrasjb

#7 @sabernhardt
6 weeks ago

Small edit: I would like a comma before "and" (posts, and changes)

@audrasjb
6 weeks ago

Administration: Clarify that discussion settings will only be applied to new posts.

#8 @audrasjb
6 weeks ago

Agree, thanks @sabernhardt. Comma added in 54300.2.diff.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


5 weeks ago

#10 @audrasjb
5 weeks ago

  • Keywords commit added

As per today's bug scrub, I'm marking this for commit as it was reviewed by two people and the patch still applies cleanly against trunk :)

#11 @johnjamesjacoby
5 weeks ago

I'd like to offer up another iteration:

'Individual posts may override these settings. Changes here will only be applied to new posts.'
  • Moves the "individual posts" caveat to the beginning, for improved emphasis
  • Removes double usage of the word "for" which helps reduce ambiguity between sentence sections
  • Break single sentence into 2 statements of fact, to make them each easier to understand separately
  • Move the word "only" from the end to the middle to improve sentence flow

What do y'all think? 🧐

#12 @tobifjellner
5 weeks ago

What do y'all think? 🧐

I like 3.diff!

#13 @audrasjb
5 weeks ago

Looks great to me, thanks @johnjamesjacoby !

#14 @johnjamesjacoby
5 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 51976:

Admin/Discussion Settings: attempt to clarify intent of "Default post settings" section.

This changes the descriptive text underneath 3 settings that are frequently overridden by individual posts & pages, and are also often misunderstood to work differently than they do.

"(These settings may be overridden for individual posts.)"

...becomes...

"Individual posts may override these settings. Changes here will only be applied to new posts."

  • Parenthesis were removed to improve text layout and flow for RTL languages.
  • Original statement was reworded to emphasize "individual posts".
  • New statement provides clarity to users about settings changes not being retroactive.

Props audrasjb, johnjamesjacoby, sabbirshouvo, sabernhardt, tobifjellner.

Fixes #54300.

Note: See TracTickets for help on using tickets.