Make WordPress Core

Opened 3 years ago

Last modified 20 months ago

#54334 new task (blessed)

E2E tests for Uploading New Version of Themes & Plugins

Reported by: juhise's profile juhise Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch has-unit-tests needs-refresh
Focuses: Cc:

Description

This is the feature of showing notice when uploading a new version of an already installed theme/plugin

This ticket is to add E2E test for this feature

Change History (17)

This ticket was mentioned in PR #1786 on WordPress/wordpress-develop by juhi123.


3 years ago
#1

  • Keywords has-patch has-unit-tests added

Related Trac Ticket: https://core.trac.wordpress.org/ticket/54334

---

# Test Scenario

## Install the old plugin from the uploader

Given that plugin zip is present
Go to Plugin -> Add New
Click on Upload Plugin
Choose File: Upload the older version of the plugin
When I click on Install, I should see the Activate Plugin button

I go to plugins->installed plugin and should see old plugin version

## Install the new plugin from the uploader

Given that plugin zip is present
Go to Plugin -> Add New
Click on Upload Plugin
Choose File: Upload the new version of the plugin
When I click on Install, I see the `Replace current with uploaded
` button
When I click on “Replace current with uploaded” I should see the Activate Plugin button

I go to plugins->installed plugin and should see the new plugin version

## Cancel the old version upload
Given that plugin zip is present
Go to Plugin -> Add New
Click on Upload Plugin
Choose File: Upload the older version of the plugin
When I click on Cancel and go back, I should be on plugin-install.php URL

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.9

This ticket was mentioned in PR #1807 on WordPress/wordpress-develop by JustinyAhin.


3 years ago
#3

Related Trac Ticket: https://core.trac.wordpress.org/ticket/54334

## Tests scenarios

  • Replace an installed theme with a different version by uploading
  • Cancel and go back while uploading a new theme version

This ticket was mentioned in PR #1813 on WordPress/wordpress-develop by JustinyAhin.


3 years ago
#4

Related Trac Ticket: https://core.trac.wordpress.org/ticket/54334

## Test Scenario

  • Replace the old theme by uploading a new version
  • Cancel and go back to the old theme while uploading a new version

JustinyAhin commented on PR #1813:


3 years ago
#5

@kevin940726 @tellthemachines @hellofromtonya this PR is ready for reviews.
cc @juhi123

JustinyAhin commented on PR #1813:


3 years ago
#6

Hi @kevin940726 👋🏻
Any updates for your review? I also created this PR https://github.com/WordPress/wordpress-develop/pull/1858 for the helpers for e2e in Core.

kevin940726 commented on PR #1813:


3 years ago
#7

Hi @JustinyAhin! Sorry, been busy with 5.9 and other things. I'll try to find some time to review this 🙇‍♂️ !

JustinyAhin commented on PR #1813:


3 years ago
#8

Hi @JustinyAhin! Sorry, been busy with 5.9 and other things. I'll try to find some time to review this 🙇‍♂️ !

Thank you, Kevin :)

#9 @hellofromTonya
3 years ago

  • Milestone changed from 5.9 to 6.0

As today is 5.9 Beta 1, moving this to 6.0. Tests are not strictly bound to a milestone. Once the patch is approved and ready, it can committed.

This ticket was mentioned in PR #1931 on WordPress/wordpress-develop by JustinyAhin.


3 years ago
#10

Related Trac Ticket: https://core.trac.wordpress.org/ticket/54334

## Test Scenario

  • Replace the old plugin when uploading a new version
  • Cancel and go back to the old plugin while uploading a new version

JustinyAhin commented on PR #1931:


2 years ago
#11

Cc @kevin940726, when you have some time, this PR might need some review.

#12 @costdev
2 years ago

  • Type changed from defect (bug) to task (blessed)

#13 @hellofromTonya
2 years ago

  • Milestone changed from 6.0 to 6.1

Moving this to 6.1, as 6.0 RC1 tomorrow. As this is part of the test suite, it can be committed at any time when reviewed and ready.

#14 @desrosj
20 months ago

  • Keywords needs-refresh added
  • Milestone changed from 6.1 to Future Release

@juhise @justinahinon could you refresh these PRs to include all of the changes to trunk since created?

This has already been punted twice, so I'm going to punt this to Future Release. Once the PRs are refreshed and a Core committer is able to focus on getting these merged, it can be moved back to a numbered milestone.

@juhise commented on PR #1786:


20 months ago
#15

I have merged the trunk into this.

#16 @costdev
20 months ago

Looks like the PR needs to be changed to compare against WordPress:trunk instead of WordPress:master.

Last edited 20 months ago by costdev (previous) (diff)

#17 @juhise
20 months ago

@costdev I made the change, hope it's fine now.

Note: See TracTickets for help on using tickets.