WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#54506 closed task (blessed) (fixed)

Remove Navigation Areas

Reported by: noisysocks Owned by: spacedmonkey
Priority: normal Milestone: 5.9
Component: Editor Version: 5.9
Severity: normal Keywords: has-patch has-unit-tests commit
Cc: Focuses: rest-api

Description

In ​https://github.com/WordPress/gutenberg/issues/36524 it was decided to remove the Navigation Areas functionality for WP 5.9. We will need to remove the wp_navigation_area CPT and wp-includes/navigation-areas.php code from Core.

Change History (16)

#1 in reply to: ↑ description @noisysocks
5 years ago

Replying to noisysocks:

In ​https://github.com/WordPress/gutenberg/issues/36524 it was decided to remove the Navigation Areas functionality for WP 5.9. We will need to remove the navigation area endpoints and wp-includes/navigation-areas.php code from Core.

This ticket was mentioned in ​PR #1944 on ​WordPress/wordpress-develop by ​noisysocks.
5 years ago #2

  • Keywords has-patch has-unit-tests added; needs-patch removed

This removes the Navigation Area endpoints and utility functions from Core. In ​https://github.com/WordPress/gutenberg/issues/36524 it was decided to remove the Navigation Area functionality form WP 5.9.

Trac ticket: https://core.trac.wordpress.org/ticket/54506

​noisysocks commented on ​PR #1944:
5 years ago #3

Not sure why GitHub isn't letting me request a review from @getdave 🤔

​getdave commented on ​PR #1944:
5 years ago #4

Not sure why GitHub isn't letting me request a review from @getdave 🤔

I guess because I haven't committed here before or something?

​getdave commented on ​PR #1944:
5 years ago #5

I tried to testing this but my local WordPress develop setup wouldn't start up. Adam's 👍 is good enough for me.

#6 @spacedmonkey
5 years ago

  • Focuses rest-api added
  • Version → trunk

This ticket was mentioned in ​Slack in #core-restapi by spacedmonkey. ​View the logs.
5 years ago

​spacedmonkey commented on ​PR #1944:
5 years ago #8

This looks good @noisysocks . Happy to commit?

#9 @spacedmonkey
5 years ago

  • Keywords commit added

​getdave commented on ​PR #1944:
5 years ago #10

This looks good @noisysocks . Happy to commit?

If you wouldn't mind committing @spacedmonkey I think we're good to go.

#12 @spacedmonkey
5 years ago

  • Owner set to spacedmonkey
  • Resolution → fixed
  • Status new → closed

In 52272:

Editor: Remove Navigation Areas

Navigation area were merged as part of full site editing and the new navigation block. This functionality is experimental and not currently used in WordPress core, so should be removed.

Props noisysocks, spacedmonkey, get_dave, zieladam.
Fixes #54506.

This ticket was mentioned in ​Slack in #core-committers by hellofromtonya. ​View the logs.
5 years ago

#14 @noisysocks
5 years ago

In 52273:

Restore block PHP to canonical version in @wordpress/block-library

r52272 erroneously modified src/wp-includes/blocks/navigation.php. This file
is copied from @wordpress/block-library and so must be updated via npm. This
commit restores the file by running grunt build --dev.

Follows [52272].
See #54506.

#15 @peterwilsoncc
5 years ago

In 52274:

Build/Test Tools: Revert ignore prop change in [52272].

See #54506.

Note: See TracTickets for help on using tickets.