Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#54581 closed defect (bug) (fixed)

long "New Application Password Name" bleeds out of frame

Reported by: presskopp's profile Presskopp Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: minor Version:
Component: Application Passwords Keywords: has-screenshots good-first-bug has-patch commit
Focuses: ui, administration Cc:

Description

Yes, it's an edge case, but still..

Using a veeeery long Application Password Name it won't be shown but jumps out of the box.

Patch:

#application-passwords-section .notice {
    word-wrap: break-word;
}

Attachments (5)

longlonglong.jpg (71.4 KB) - added by Presskopp 3 years ago.
longlonglongpatch.jpg (1.3 MB) - added by Presskopp 3 years ago.
with patch
54581.diff (380 bytes) - added by hasanuzzamanshamim 3 years ago.
I tested on trunk, "word-wrap: break-word" CSS will fix this issue.
4cacce257898f82f7519b49e3a3ee5fd.gif (1.4 MB) - added by audrasjb 2 years ago.
Before patch
Capture d’écran 2022-06-24 à 00.41.56.png (338.8 KB) - added by audrasjb 2 years ago.
After patch: problem solved!

Change History (16)

@Presskopp
3 years ago

with patch

#1 @Presskopp
3 years ago

Should this be limited to a maximum number of characters?

#2 @SergeyBiryukov
3 years ago

  • Component changed from Administration to Application Passwords
  • Focuses ui administration added

#3 @Presskopp
3 years ago

  • Keywords good-first-bug added

@hasanuzzamanshamim
3 years ago

I tested on trunk, "word-wrap: break-word" CSS will fix this issue.

#4 @hasanuzzamanshamim
3 years ago

  • Keywords has-patch added; needs-patch removed

#5 @yannielsen
2 years ago

Also tested on trunk and the CSS will fix the issue described.

#8 @audrasjb
2 years ago

The above PR refreshes the previous patch proposal.

@audrasjb
2 years ago

After patch: problem solved!

#9 @audrasjb
2 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.1

Marking for commit and moving to milestone 6.1.

#10 @audrasjb
2 years ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 53567:

Application Passwords: Ensure long passwords don't break the "new password" notice.

This changeset adds a word-wrap: break-word CSS declaration to avoid text overflow in the "new application password" notice.

Props Presskopp, hasanuzzamanshamim, yannielsen, audrasjb.
Fixes #54581.

Note: See TracTickets for help on using tickets.