Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54625 closed defect (bug) (reported-upstream)

Comments markup differs in trunk from the markup provided with the Gutenberg plugin active

Reported by: kjellr's profile kjellr Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords:
Focuses: Cc:


When testing the 5.9 Beta, the comments markup outputted by the "Post Comments" block differs from that outputted by the Gutenberg plugin. This results in some mis-aligned details.

Gutenberg Plugin:

5.9 Beta:

Tested with 5.9 Beta 3 (tested via trunk) and Gutenberg 5.8.2 (via trunk)

cc @noisysocks

Change History (7)

This ticket was mentioned in Slack in #core by kjell. View the logs.

2 years ago

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.

2 years ago

#3 @noisysocks
2 years ago

It looks like this came as a result of #54597 making it so that in Core we opt in to HTML5 markup for comment-form, comment-list, style and script:

In Gutenberg we only opt in to HTML5 markup for style and script:

I can make it so that the behaviours in Core and Gutenberg match, but which is correct, @kjellr? We should aim to use HTML5 markup, no?

Last edited 2 years ago by SergeyBiryukov (previous) (diff)

#4 @kjellr
2 years ago

Hmm, interesting. presumably it would make sense to opt into the markup as well. But if we do that, we'll also need to push some style updates in order to ensure that the block is properly rendered. The current Gutenberg appearance (with smaller meta font sizes, non-bold author name, and a post meta that doesn't slide off the screen) should be the target.

#5 @hellofromTonya
2 years ago

Opened an issue in Gutenberg to add the comment-form and comment-list to the html5 theme supports

@kjellr is there additional work that needs to be done in TT2? Should an issue be opened in the TT2 repo?

#6 @kjellr
2 years ago

No, Twenty Twenty-Two isn't styling the comments form at all (nor should it, I don't think). Changes in core should be enough, but I think CSS changes might be necessary there to fix the visual issues noted above. I'll add a comment to the ticket.

#7 @hellofromTonya
2 years ago

  • Milestone 5.9 deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

Thanks @kjellr. As this is now reported upstream in Gutenberg and will be added into Core during an backport update, I'll close this ticket. Tracking then shifts to Gutenberg for resolution.

Note: See TracTickets for help on using tickets.