Comments markup differs in trunk from the markup provided with the Gutenberg plugin active

[kjellr]

When testing the 5.9 Beta, the comments markup outputted by the "Post Comments" block differs from that outputted by the Gutenberg plugin. This results in some mis-aligned details.

Gutenberg Plugin:

5.9 Beta:

---

Tested with 5.9 Beta 3 (tested via trunk) and Gutenberg 5.8.2 (via trunk)

cc @noisysocks

[noisysocks]

It looks like this came as a result of #54597 making it so that in Core we opt in to HTML5 markup for comment-form, comment-list, style and script:

​https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/theme.php#L4179

In Gutenberg we only opt in to HTML5 markup for style and script:

​https://github.com/WordPress/gutenberg/blob/7762302a2aacd1da09d7c848ce009598aca21ef9/lib/compat/wordpress-5.9/default-theme-supports.php#L12-L18

I can make it so that the behaviours in Core and Gutenberg match, but which is correct, @kjellr? We should aim to use HTML5 markup, no?

[kjellr]

Hmm, interesting. presumably it would make sense to opt into the markup as well. But if we do that, we'll also need to push some style updates in order to ensure that the block is properly rendered. The current Gutenberg appearance (with smaller meta font sizes, non-bold author name, and a post meta that doesn't slide off the screen) should be the target.

[hellofromTonya]

Opened an issue in Gutenberg to add the comment-form and comment-list to the html5 theme supports ​https://github.com/WordPress/gutenberg/issues/37464.

@kjellr is there additional work that needs to be done in TT2? Should an issue be opened in the TT2 repo?

[kjellr]

No, Twenty Twenty-Two isn't styling the comments form at all (nor should it, I don't think). Changes in core should be enough, but I think CSS changes might be necessary there to fix the visual issues noted above. I'll add a comment to the ticket.

[hellofromTonya]

Thanks @kjellr. As this is now reported upstream in Gutenberg and will be added into Core during an backport update, I'll close this ticket. Tracking then shifts to Gutenberg for resolution.