Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#54639 closed defect (bug) (wontfix)

Update Query Loop patterns with less posts per page

Reported by: ntsekouras's profile ntsekouras Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

I think we need to 'lighten' the Query Loop patterns regarding the number of posts it previews. The point of a pattern is to showcase some design and with some pre-selected blocks(the inner Post blocks, etc..). It's already opinionated about the number of posts, so we could just show the minimum number required to make the pattern show its point.

We need to find a good way to handle patterns performance in core, but for 5.9 is the least we can do.

The Gutenberg PR for this change is here: https://github.com/WordPress/gutenberg/pull/37475

Similar PR for TwentyTwentyTwo theme is here: https://github.com/WordPress/twentytwentytwo/pull/304

Change History (9)

This ticket was mentioned in PR #2063 on WordPress/wordpress-develop by ntsekouras.


3 years ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/54639

I think we need to 'lighten' the Query Loop patterns regarding the number of posts it previews. The point of a pattern is to showcase some design and with some pre-selected blocks(the inner Post blocks, etc..). It's already opinionated about the number of posts, so we could just show the minimum number required to make the pattern show its point.

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.9

Thanks for the ticket! Moving to 5.9 for visibility.

ntsekouras commented on PR #2063:


3 years ago
#3

Thanks for reviewing @SergeyBiryukov , but let's wait just a bit before merging as there were some concerns raised about this by @mtias here: https://github.com/WordPress/gutenberg/pull/37475#issuecomment-996534835.

There is the possibility of reverting the GB PR and that would make this PR obsolete.

mcsf commented on PR #2063:


3 years ago
#4

I was hoping that my review at https://github.com/WordPress/wordpress-develop/pull/2063#pullrequestreview-835446418 would add a red "changes requested" mention by the merge button. It apparently didn't, so merger beware. :)

#5 @hellofromTonya
3 years ago

Gutenberg's PR 37475 has been merged into Gutenberg's trunk and is marked for backporting. Will monitor to ensure it's part of the Beta 4 resync updates patch that @isabel_brison will be doing for Beta 4.

The TT2 PR however was not part of the resync for Beta 4. cc @jffng @kjellr Can this PR be ready and backported for Beta 4?

#6 follow-up: @jffng
3 years ago

Looking at the TT2 PR, it looks there is still some discussion to be had before merging. Will take another look but if we have to reduce the number of posts per page, I'd prefer to get @kjellr to take another look at each pattern and determine what is the right number of posts to show for each Query pattern while still providing a good preview experience.

#7 in reply to: ↑ 6 @hellofromTonya
3 years ago

Replying to jffng:

Looking at the TT2 PR, it looks there is still some discussion to be had before merging. Will take another look but if we have to reduce the number of posts per page, I'd prefer to get @kjellr to take another look at each pattern and determine what is the right number of posts to show for each Query pattern while still providing a good preview experience.

Thanks @jffng. I just realized, DOH, that this patch is on hold and may be reverted from the Gutenberg plugin. Waiting on a decision from Matias.


NOTE FOR CORE COMMITTERS:
The patch in this ticket is on hold pending a decision from Matias.

ntsekouras commented on PR #2063:


3 years ago
#8

I'm closing this as we reverted the GB PR eventually.

#9 @hellofromTonya
3 years ago

  • Milestone 5.9 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Closing this ticket as https://github.com/WordPress/gutenberg/pull/37475 was reverted.

Note: See TracTickets for help on using tickets.