WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#54643 closed defect (bug) (fixed)

5.9 string changes from Gutenberg backports (after Beta 3)

Reported by: get_dave's profile get_dave Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords: i18n-change
Focuses: ui-copy Cc:

Description (last modified by hellofromTonya)

This ticket tracks all string changes from Gutenberg backports. Each backport will be listed separately.

These 2 PRs for the Nav block:

I'm aware that string freeze has happened and I wouldn't ask for these to be considered except that they [fix a bug in Nav block which would otherwise leave it inoperable for users with lower permissions]​https://github.com/WordPress/gutenberg/issues/36286.

Change History (11)

#1 @get_dave
3 years ago

Also noting ​https://github.com/WordPress/gutenberg/pull/37486 which I didn't include in the original ticket description. I'd also really appreciate this to be considered for inclusion if it lands.

#2 @audrasjb
3 years ago

  • Milestone changed from Awaiting Review to 5.9
  • Version set to trunk

#3 @isabel_brison
3 years ago

  • Summary changed from String changes for adding permissions handling for Navigation block to String changes for 5.9 Beta 4

Hijacking this ticket to track all the string changes we need in Beta 4. In addition to the 2 already mentioned PRs, we also have:

​https://github.com/WordPress/gutenberg/pull/37497

​https://github.com/WordPress/gutenberg/pull/37434

​https://github.com/WordPress/gutenberg/pull/37216

​https://github.com/WordPress/gutenberg/pull/36897

#4 @hellofromTonya
3 years ago

  • Description modified (diff)
  • Summary changed from String changes for 5.9 Beta 4 to String changes from Gutenberg backports

#5 @hellofromTonya
3 years ago

  • Summary changed from String changes from Gutenberg backports to 5.9 string changes from Gutenberg backports (after Beta 3)

#6 @hellofromTonya
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

With RC1 today, closing this ticket.

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
3 years ago

#8 @noisysocks
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

These two PRs which were backported just before RC 1 included some new strings and a switch from _ to _x:

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs.
3 years ago

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs.
3 years ago

#11 @hellofromTonya
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.