Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#54859 closed defect (bug) (reported-upstream)

New Welcome's panel "Edit styles" link does not seem to work

Reported by: davidbinda's profile david.binda Owned by: hellofromtonya's profile hellofromTonya
Milestone: Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords:
Focuses: ui, administration Cc:

Description

Per https://core.trac.wordpress.org/ticket/54489#comment:22 , the link with the Edit styles text in the dasboard's welcome panel, using the wp-admin/site-editor.php?styles=open URL, should automatically open the new Styles panel, but in my testing, it does not seem to work, and the screen I'm taken to is not much different from the other one; the Open site editor text linking to wp-admin/site-editor.php.

Reproduction steps:

  1. Install the latest nightly using the beta tester plugin
  2. Navigate to wp-admin's dashboard
  3. Click on the "Edit styles" link in the welcome panel
  4. I'm landing on a site editor screen with no panels open, and a welcome guide for the settings panel.

What I would expect:

  1. Land on a site editor screen with styles panel open and welcome guide for the styles panel to be open.

Attachments (1)

54859-test-fix.gif (1.4 MB) - added by hellofromTonya 2 years ago.
Test Report for [52625] which includes restoring ?styles=open functionality. Clicking on Site styles in the Dashboard's Welcome to WordPress ✅panel works again

Download all attachments as: .zip

Change History (12)

#1 @joyously
2 years ago

Comment 26 (https://core.trac.wordpress.org/ticket/54489#comment:26) says

For example, if you're logged in as an author and not an editor. In this case the Customize Your Site and Edit styles links won't work.

The welcome panel only shows up if you have edit_theme_options, which works for the Customizer link… but I realize I don't know which capabilities are needed for the site editor/styles. Is is still edit_theme_options?

That's quite a long ticket, so it's hard to tell if that ever got resolved.

#2 @david.binda
2 years ago

Thanks for pointing out the capability issues. My tests were performed under an admin user, tho, so capabilities should not be an issue, I guess.

#3 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 5.9

Thanks for the ticket! Moving to the milestone for visibility.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 years ago

#5 @hellofromTonya
2 years ago

  • Component changed from General to Editor

I can reproduce this issue.

@noisysocks @mamaduka Should the wp-admin/site-editor.php?styles=open open the Styles area in the Site Editor? Is this the right URL? Or is this a bug that needs fixing in Gutenberg first?

My thinking here is to get this fixed and if another issue pops, then bundle for a RC4.

#6 @hellofromTonya
2 years ago

  • Owner set to hellofromTonya
  • Status changed from new to assigned

#8 @hellofromTonya
2 years ago

The URL is correct. However, the ?styles=open functionality, which automatically opens the Styles panel from that URL, was accidentally removed. It's been restored and fixed in Gutenberg (see the merged PR and closed issue).

Is this bug critical and a blocker for the final release? In other words, does this bug warrant a RC4? From yesterday's dev chat, there's consensus that it does not.

Why?

  • Clicking the link takes the user to the Site Editor where one more click opens the Styles panel.
  • The user is not left in an usable or broken state, nor does it cause a fatal error or break the website.

Granted, it's not an ideal nor a perfect experience. But on its own, it does not warrant a RC4. That said, if another issue is reported that does rise to the level of critical blocker, then the fix for this issue will be bundled into RC4.

What to do with this ticket? To ensure it stays on the radar in case a RC4 happens, let's leave this issue open and in 5.9 for visibility. Then before the 24 hour code freeze, close it as reported upstream (as the fix will be backported from Gutenberg for 5.9.1).

This ticket was mentioned in Slack in #core by kjell. View the logs.


2 years ago

@hellofromTonya
2 years ago

Test Report for [52625] which includes restoring ?styles=open functionality. Clicking on Site styles in the Dashboard's Welcome to WordPress ✅panel works again

#10 @hellofromTonya
2 years ago

  • Milestone 5.9 deleted
  • Resolution set to reported-upstream
  • Status changed from assigned to closed

This issue was fixed in Gutenberg https://github.com/WordPress/gutenberg/pull/38093.

Earlier today the fix for this issue was backported to trunk with changeset [52624] and to the 5.9 branch with changeset [52625]. 54859-test-fix.gif shows the fix does restore the ?styles=open functionality.

A blocking issue emerged yesterday that triggered a RC4. As the fix in this ticket was queued in case a RC4 happened, it will be included in today's RC4.

Thank you all for contributing 🎉

Closing this ticket. Marking it was reported and fixed upstream.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.