Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54872 closed defect (bug) (reported-upstream)

In Mobile view cancel button's bottom part is hiding behind the options block

Reported by: krupalpanchal's profile krupalpanchal Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords:
Focuses: accessibility, css Cc:

Description

When you add a new section in the post, in Mobile view cancel button's bottom part is hiding behind the block editor's options block. There is a given focus property on a button, So it might need some space below the button to see the proper design.

Attachments (1)

mobile-view.png (13.8 KB) - added by krupalpanchal 2 years ago.
Mobile view of adding editor block

Download all attachments as: .zip

Change History (7)

@krupalpanchal
2 years ago

Mobile view of adding editor block

#1 @krupalpanchal
2 years ago

  • Version set to trunk

#2 @sabernhardt
2 years ago

  • Component changed from General to Editor
  • Focuses accessibility css added
  • Keywords needs-design removed

Thanks for the report!

The .edit-site-editor__inserter-panel-header container has padding on the top and right, and it might need bottom padding, too.

I also can get stuck tabbing between the Cancel button and the block-editor-inserter__main-area div when I have zoom at 200% on my laptop screen.

#3 @hellofromTonya
2 years ago

Hello @krupalpanchal,

Welcome back to WordPress Core's Trac!

As @sabernhardt noted, seems bottom padding is needed. That adjustment would be made upstream in the Gutenberg project, packages published, and then updates backported to WordPress Core.

Please report the issue here https://github.com/WordPress/gutenberg/issues/new?assignees=&labels=&template=Bug_report.yml. If you don't mind, please copy and paste the issue URL as a comment back here in this Trac ticket, i.e. to bind the 2 issue reports together. Thank you!

#4 @hellofromTonya
2 years ago

  • Milestone changed from Awaiting Review to 5.9.1

I'll move this ticket into 5.9.1 for visibility. Once reported upstream, this ticket can be closed as it'll be tracked, investigated, and resolved in Gutenberg.

#5 @krupalpanchal
2 years ago

Hello @hellofromTonya

I've added an issue on GitHub, and here is the link: https://github.com/WordPress/gutenberg/issues/38140

#6 @hellofromTonya
2 years ago

  • Milestone 5.9.1 deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

Awesome, thank you @krupalpanchal 🙌

Tracking and progress will be move to here https://github.com/WordPress/gutenberg/issues/38140.

Closing this ticket as reported upstream.

Note: See TracTickets for help on using tickets.