Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#54971 closed enhancement (fixed)

Theme Details button cursor does not match cursor when hovering over screenshot

Reported by: multidots1896's profile multidots1896 Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.0 Priority: normal
Severity: normal Version: 5.8
Component: Themes Keywords: has-screenshots has-patch commit
Focuses: ui, accessibility, css, administration Cc:

Description

In WordPress 5.9 in appearance menu has themes options not showing cursor on theme details title.
we need to add cursor on theme-details title and also it shows blue outline after popup open and closing of theme-details box.
below i have added screenshot and added css.

Attachments (3)

Screenshot 2022-01-28 at 5.44.47 PM.png (589.9 KB) - added by multidots1896 2 years ago.
added screenshot
#54971.patch (561 bytes) - added by rehanali 2 years ago.
Added patch
54971.patch (371 bytes) - added by ravipatel 2 years ago.
As per core development only one file themes.css

Download all attachments as: .zip

Change History (11)

#1 @multidots1896
2 years ago

Need to add cursor:pointer css for it

.theme-browser .theme .more-details {
	-ms-filter: "progid:DXImageTransform.Microsoft.Alpha(Opacity=0)";
	opacity: 0;
	position: absolute;
	top: 35%;
	right: 20%;
	left: 20%;
	width: 60%;
	background: #1d2327;
	background: rgba(0, 0, 0, 0.7);
	color: #fff;
	font-size: 15px;
	text-shadow: 0 1px 0 rgba(0, 0, 0, 0.6);
	-webkit-font-smoothing: antialiased;
	font-weight: 600;
	padding: 15px 12px;
	text-align: center;
	border-radius: 3px;
	border: none;
	transition: opacity 0.1s ease-in-out;
	cursor: pointer;
}
Last edited 2 years ago by sabernhardt (previous) (diff)

@rehanali
2 years ago

Added patch

@ravipatel
2 years ago

As per core development only one file themes.css

#2 @sabernhardt
2 years ago

  • Component changed from General to Themes
  • Focuses accessibility administration added
  • Keywords has-patch added
  • Summary changed from In WordPress 5.9 in appearance menu has themes options not showing cursor on theme details title to Theme Details button cursor does not match cursor when hovering over screenshot
  • Type changed from feature request to enhancement
  • Version changed from 5.9 to 5.8

"Theme Details" has been a button since 5.8 (#52649), and so it has browsers' "default" cursor.

Buttons really should have that cursor (#47171) in new sites and applications; however, making it consistently pointer could be preferable in this situation. This may be the only place in the admin where a button has the 'correct' cursor.

This ticket was mentioned in Slack in #accessibility by alexstine. View the logs.


2 years ago

#4 @ryokuhi
2 years ago

In general, I would support the idea that each HTML element uses the native cursor, without changes.

In this specific case, however, there's also a consistency problem.

  • When you hover each "theme card", the cursor takes the pointer shape (i.e. the hand one).
  • When you hover the button of each "theme card", the cursor takes the default shape (i.e. the arrow one).
  • However, clicking opens the Theme Details dialog in both cases.

I think that using two different cursor shapes to get the same outcome may be confusing (if I see a change in the pointer, I expect different actions to happen on click). As such, it would probably be better change either cursor and use a single one.
My personal preference would be to use the default shape on the entire "theme card" and use this as a first step to solving #47171, but the quickest and most consistent solution across the entire WordPress interface would probably be to use the pointer shape also for the button. I'm open to both solutions, let's see if others have an opinion.

#5 @sabernhardt
2 years ago

  • Milestone changed from Awaiting Review to 6.0

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.


2 years ago

#7 @peterwilsoncc
2 years ago

  • Keywords commit added
  • Owner set to peterwilsoncc
  • Status changed from new to assigned

@ryokuhi Given your opinion matches @sabernhardt's, I think it's safe to consider the second opinion sort and provided.

#8 @peterwilsoncc
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52944:

Themes: Use pointer when hovering on theme details button.

Use the pointer cursor when hovering over the theme details button for consistency with the theme card. Clicking in either area performs the same action.

Props multidots1896, rehanali, ravipatel, sabernhardt, ryokuhi.
Fixes #54971.

Note: See TracTickets for help on using tickets.