WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#55132 closed enhancement (fixed)

Unused variable in in WP_Plugins_List_Table::single_row()

Reported by: azouamauriac Owned by: SergeyBiryukov
Priority: normal Milestone: 6.3
Component: Plugins Version:
Severity: normal Keywords:
Cc: Focuses: coding-standards

Description

in WP_Plugins_List_Table::single_row there some unused variables ($available_updates, $sortable, $primary).

some histories: [47835] [32644]

Attachments (2)

55132.diff​ (714 bytes ) - added by azouamauriac 5 years ago.
55132.2.diff​ (792 bytes ) - added by azouamauriac 5 years ago.
Remove space for phpcs. this last is good.

Download all attachments as: .zip

Change History (5)

@azouamauriac
5 years ago

@azouamauriac
5 years ago

Remove space for phpcs. this last is good.

#1 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review → 6.3
  • Owner set to SergeyBiryukov
  • Status new → reviewing

Hi there, thanks for the patch!

It looks like this exact line also exists in a few other list tables:

list( $columns, $hidden, $sortable, $primary ) = $this->get_column_info();

So I think I'd like to leave it as is for consistency, even though $sortable and $primary are not used here.

The other change looks good to me.

#2 @SergeyBiryukov
4 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 55571:

Coding Standards: Remove unused variable in WP_Plugins_List_Table::single_row().

Follow-up to [47835], [48669].

Props azouamauriac.
Fixes #55132.

#3 @SergeyBiryukov
4 years ago

  • Summary Unused variable → Unused variable in in WP_Plugins_List_Table::single_row()
Note: See TracTickets for help on using tickets.