WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#55141 closed defect (bug) (fixed)

Twenty Seventeen: Remove linked transparent image border

Reported by: mikachan's profile mikachan Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.0 Priority: normal
Severity: minor Version:
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Description

There is a small bug in the Twenty Seventeen theme, where linked images show a bottom border / box-shadow.

This was previously fixed in the themes repo, so this ticket is for replicating the fix in Core.

Original issue: ​https://github.com/Automattic/themes/issues/5018

Attachments (2)

55141.patch​ (83.2 KB) - added by nidhidhandhukiya 3 years ago.
I have solution for this issue.
55141.2.patch​ (621 bytes) - added by sabernhardt 3 years ago.
removing box shadow from linked images, including within widget areas

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in ​PR #2304 on ​WordPress/wordpress-develop by ​mikachan.
3 years ago #1

This fixes a small bug in the Twenty Seventeen theme, where transparent linked images were showing a bottom border incorrectly (via a box-shadow).

This has previously been fixed over in the themes repo, so this PR replicates the fix in Core.

Original themes issue: ​https://github.com/Automattic/themes/issues/5018

Trac ticket: https://core.trac.wordpress.org/ticket/55141

@nidhidhandhukiya
3 years ago

I have solution for this issue.

#2 @sabernhardt
3 years ago

  • Component changed from Themes to Bundled Theme

#3 @mukesh27
3 years ago

  • Keywords commit added

Hi there!

Thanks for the ticket and PR.

PR looks good to me and ready to marge.

@nidhidhandhukiya style.css generate run time so you have to add CSS in SCSS then create the patch.

Ping @SergeyBiryukov for review it.

#4 @sabernhardt
3 years ago

  • Keywords commit removed
  • Milestone changed from Awaiting Review to 6.0

Let's fix this for image blocks in (footer) widget areas, too.

@sabernhardt
3 years ago

removing box shadow from linked images, including within widget areas

#5 @sabernhardt
3 years ago

For consistency, 55141.2.patch​ has the WebKit prefix as well.

#6 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 52740:

Twenty Seventeen: Remove bottom border (box-shadow) from linked images.

Props mikachan, sabernhardt, nidhidhandhukiya, mukesh27, scruffian.
Fixes #55141.

Note: See TracTickets for help on using tickets.