Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#55395 closed task (blessed) (fixed)

Update Twemoji for 6.0

Reported by: kraftbj's profile kraftbj Owned by: kraftbj's profile kraftbj
Milestone: 6.0 Priority: normal
Severity: normal Version:
Component: Emoji Keywords: needs-user-docs add-to-field-guide
Focuses: Cc:

Description

Twitter has released Twemoji 14.0 (and 14.0.1). We can upgrade to include the new Emoji 14 fun.

Previously #52852

This release will include a number of new emoji:

๐Ÿซ  Melting Face
๐Ÿซข Face with Open Eyes and Hand Over Mouth
๐Ÿซฃ Face with Peeking Eye
๐Ÿซก Saluting Face
๐Ÿซฅ Dotted Line Face
๐Ÿซค Face with Diagonal Mouth
๐Ÿฅน Face Holding Back Tears
๐Ÿซฑ Rightwards Hand
๐Ÿซฒ Leftwards Hand
๐Ÿซณ Palm Down Hand
๐Ÿซด Palm Up Hand
๐Ÿซฐ Hand with Index Finger and Thumb Crossed
๐Ÿซต Index Pointing at the Viewer
๐Ÿซถ Heart Hands
๐Ÿซฆ Biting Lip
๐Ÿซ… Person with Crown
๐Ÿซƒ Pregnant Man
๐Ÿซ„ Pregnant Person
๐ŸงŒ Troll
๐Ÿชธ Coral
๐Ÿชท Lotus
๐Ÿชน Empty Nest
๐Ÿชบ Nest with Eggs
๐Ÿซ˜ Beans
๐Ÿซ— Pouring Liquid
๐Ÿซ™ Jar
๐Ÿ› Playground Slide
๐Ÿ›ž Wheel
๐Ÿ›Ÿ Ring Buoy
๐Ÿชฌ Hamsa
๐Ÿชฉ Mirror Ball
๐Ÿชซ Low Battery
๐Ÿฉผ Crutch
๐Ÿฉป X-Ray
๐Ÿซง Bubbles
๐Ÿชช Identification Card
๐ŸŸฐ Heavy Equals Sign
๐Ÿซฑ๐Ÿป Rightwards Hand: Light Skin Tone
๐Ÿซฑ๐Ÿผ Rightwards Hand: Medium-Light Skin Tone
๐Ÿซฑ๐Ÿฝ Rightwards Hand: Medium Skin Tone
๐Ÿซฑ๐Ÿพ Rightwards Hand: Medium-Dark Skin Tone
๐Ÿซฑ๐Ÿฟ Rightwards Hand: Dark Skin Tone
๐Ÿซฒ๐Ÿป Leftwards Hand: Light Skin Tone
๐Ÿซฒ๐Ÿผ Leftwards Hand: Medium-Light Skin Tone
๐Ÿซฒ๐Ÿฝ Leftwards Hand: Medium Skin Tone
๐Ÿซฒ๐Ÿพ Leftwards Hand: Medium-Dark Skin Tone
๐Ÿซฒ๐Ÿฟ Leftwards Hand: Dark Skin Tone
๐Ÿซณ๐Ÿป Palm Down Hand: Light Skin Tone
๐Ÿซณ๐Ÿผ Palm Down Hand: Medium-Light Skin Tone
๐Ÿซณ๐Ÿฝ Palm Down Hand: Medium Skin Tone
๐Ÿซณ๐Ÿพ Palm Down Hand: Medium-Dark Skin Tone
๐Ÿซณ๐Ÿฟ Palm Down Hand: Dark Skin Tone
๐Ÿซด๐Ÿป Palm Up Hand: Light Skin Tone
๐Ÿซด๐Ÿผ Palm Up Hand: Medium-Light Skin Tone
๐Ÿซด๐Ÿฝ Palm Up Hand: Medium Skin Tone
๐Ÿซด๐Ÿพ Palm Up Hand: Medium-Dark Skin Tone
๐Ÿซด๐Ÿฟ Palm Up Hand: Dark Skin Tone
๐Ÿซฐ๐Ÿป Hand with Index Finger and Thumb Crossed: Light Skin Tone
๐Ÿซฐ๐Ÿผ Hand with Index Finger and Thumb Crossed: Medium-Light Skin Tone
๐Ÿซฐ๐Ÿฝ Hand with Index Finger and Thumb Crossed: Medium Skin Tone
๐Ÿซฐ๐Ÿพ Hand with Index Finger and Thumb Crossed: Medium-Dark Skin Tone
๐Ÿซฐ๐Ÿฟ Hand with Index Finger and Thumb Crossed: Dark Skin Tone
๐Ÿซต๐Ÿป Index Pointing at the Viewer: Light Skin Tone
๐Ÿซต๐Ÿผ Index Pointing at the Viewer: Medium-Light Skin Tone
๐Ÿซต๐Ÿฝ Index Pointing at the Viewer: Medium Skin Tone
๐Ÿซต๐Ÿพ Index Pointing at the Viewer: Medium-Dark Skin Tone
๐Ÿซต๐Ÿฟ Index Pointing at the Viewer: Dark Skin Tone
๐Ÿซถ๐Ÿป Heart Hands: Light Skin Tone
๐Ÿซถ๐Ÿผ Heart Hands: Medium-Light Skin Tone
๐Ÿซถ๐Ÿฝ Heart Hands: Medium Skin Tone
๐Ÿซถ๐Ÿพ Heart Hands: Medium-Dark Skin Tone
๐Ÿซถ๐Ÿฟ Heart Hands: Dark Skin Tone
๐Ÿค๐Ÿป Handshake: Light Skin Tone
๐Ÿค๐Ÿผ Handshake: Medium-Light Skin Tone
๐Ÿค๐Ÿฝ Handshake: Medium Skin Tone
๐Ÿค๐Ÿพ Handshake: Medium-Dark Skin Tone
๐Ÿค๐Ÿฟ Handshake: Dark Skin Tone
๐Ÿซฑ๐Ÿปโ€๐Ÿซฒ๐Ÿผ Handshake: Light Skin Tone, Medium-Light Skin Tone
๐Ÿซฑ๐Ÿปโ€๐Ÿซฒ๐Ÿฝ Handshake: Light Skin Tone, Medium Skin Tone
๐Ÿซฑ๐Ÿปโ€๐Ÿซฒ๐Ÿพ Handshake: Light Skin Tone, Medium-Dark Skin Tone
๐Ÿซฑ๐Ÿปโ€๐Ÿซฒ๐Ÿฟ Handshake: Light Skin Tone, Dark Skin Tone
๐Ÿซฑ๐Ÿผโ€๐Ÿซฒ๐Ÿป Handshake: Medium-Light Skin Tone, Light Skin Tone
๐Ÿซฑ๐Ÿผโ€๐Ÿซฒ๐Ÿฝ Handshake: Medium-Light Skin Tone, Medium Skin Tone
๐Ÿซฑ๐Ÿผโ€๐Ÿซฒ๐Ÿพ Handshake: Medium-Light Skin Tone, Medium-Dark Skin Tone
๐Ÿซฑ๐Ÿผโ€๐Ÿซฒ๐Ÿฟ Handshake: Medium-Light Skin Tone, Dark Skin Tone
๐Ÿซฑ๐Ÿฝโ€๐Ÿซฒ๐Ÿป Handshake: Medium Skin Tone, Light Skin Tone
๐Ÿซฑ๐Ÿฝโ€๐Ÿซฒ๐Ÿผ Handshake: Medium Skin Tone, Medium-Light Skin Tone
๐Ÿซฑ๐Ÿฝโ€๐Ÿซฒ๐Ÿพ Handshake: Medium Skin Tone, Medium-Dark Skin Tone
๐Ÿซฑ๐Ÿฝโ€๐Ÿซฒ๐Ÿฟ Handshake: Medium Skin Tone, Dark Skin Tone
๐Ÿซฑ๐Ÿพโ€๐Ÿซฒ๐Ÿป Handshake: Medium-Dark Skin Tone, Light Skin Tone
๐Ÿซฑ๐Ÿพโ€๐Ÿซฒ๐Ÿผ Handshake: Medium-Dark Skin Tone, Medium-Light Skin Tone
๐Ÿซฑ๐Ÿพโ€๐Ÿซฒ๐Ÿฝ Handshake: Medium-Dark Skin Tone, Medium Skin Tone
๐Ÿซฑ๐Ÿพโ€๐Ÿซฒ๐Ÿฟ Handshake: Medium-Dark Skin Tone, Dark Skin Tone
๐Ÿซฑ๐Ÿฟโ€๐Ÿซฒ๐Ÿป Handshake: Dark Skin Tone, Light Skin Tone
๐Ÿซฑ๐Ÿฟโ€๐Ÿซฒ๐Ÿผ Handshake: Dark Skin Tone, Medium-Light Skin Tone
๐Ÿซฑ๐Ÿฟโ€๐Ÿซฒ๐Ÿฝ Handshake: Dark Skin Tone, Medium Skin Tone
๐Ÿซฑ๐Ÿฟโ€๐Ÿซฒ๐Ÿพ Handshake: Dark Skin Tone, Medium-Dark Skin Tone
๐Ÿซ…๐Ÿป Person with Crown: Light Skin Tone
๐Ÿซ…๐Ÿผ Person with Crown: Medium-Light Skin Tone
๐Ÿซ…๐Ÿฝ Person with Crown: Medium Skin Tone
๐Ÿซ…๐Ÿพ Person with Crown: Medium-Dark Skin Tone
๐Ÿซ…๐Ÿฟ Person with Crown: Dark Skin Tone
๐Ÿซƒ๐Ÿป Pregnant Man: Light Skin Tone
๐Ÿซƒ๐Ÿผ Pregnant Man: Medium-Light Skin Tone
๐Ÿซƒ๐Ÿฝ Pregnant Man: Medium Skin Tone
๐Ÿซƒ๐Ÿพ Pregnant Man: Medium-Dark Skin Tone
๐Ÿซƒ๐Ÿฟ Pregnant Man: Dark Skin Tone
๐Ÿซ„๐Ÿป Pregnant Person: Light Skin Tone
๐Ÿซ„๐Ÿผ Pregnant Person: Medium-Light Skin Tone
๐Ÿซ„๐Ÿฝ Pregnant Person: Medium Skin Tone
๐Ÿซ„๐Ÿพ Pregnant Person: Medium-Dark Skin Tone
๐Ÿซ„๐Ÿฟ Pregnant Person: Dark Skin Tone

source: โ€‹https://blog.emojipedia.org/twemoji-14-0-emoji-changelog/

Change History (15)

This ticket was mentioned in โ€‹PR #2416 on โ€‹WordPress/wordpress-develop by โ€‹kraftbj.


4 years ago
#1

  • Keywords has-patch added

Adds Twemoji 14.0.1 support.
Update the regex (output of grunt precommit:emoji)
Updates the CDN URL to 14.0.1 (still needs uploading on the w.org side)
NEEDED: Detection script update.

Emoji 14 does not add any ZWJ-based emoji, unlike the past standards, so our script to detect needs a bit more work than usual. I didn't think about this and most of my computers are already upgraded to supported OS versions, so will get an old computer out of the closet to help figure out a good way to
detect it with as little change to the code as feasible.

Trac ticket: https://core.trac.wordpress.org/ticket/55395

#2 @kraftbj
4 years ago

  • Keywords has-patch removed
  • Owner set to kraftbj
  • Status changed from new to accepted

โ€‹peterwilsoncc commented on โ€‹PR #2416:


4 years ago
#3

Some of the handshake emoji include ZWJ (U+200D), for example โ€‹https://emojipedia.org/handshake-light-skin-tone-medium-light-skin-tone/

#4 @peterwilsoncc
4 years ago

  • Type changed from enhancement to task (blessed)

Marking this a task rather than an enhancement, work can continue after the enhancement deadline.

#5 @milana_cap
4 years ago

  • Keywords needs-codex added

โ€‹desrosj commented on โ€‹PR #2416:


4 years ago
#6

I've made a few updates!

  • Synced with trunk.
  • I changed the URLs to be 14.0.0 instead of 14.0.1. Since these new emoji were introduced in 14.0.0, I think it makes more sense to use that version for this update.
  • I opted to use the โ€‹Handshake: Light Skin Tone, Dark Skin Tone. I've updated the necessary locations.

I've tested this on my machine (which does not yet have Emoji 14 support) by replacing the Core CDN URLs with the GitHub ones for the Twemoji repo (โ€‹https://github.com/twitter/twemoji/raw/v14.0.2/assets/), and all seems to be working as expected!

โ€‹kraftbj commented on โ€‹PR #2416:


4 years ago
#7

Thanks for the updated patch! I've confirmed it does replace on my older device that doesn't support Emoji 14 and does not replace on my upgraded device with 14 support.

We need to coordinate with a CDN committer to get the assets added, but once that's done, this is good to go.

This ticket was mentioned in โ€‹Slack in #meta by peterwilsoncc. โ€‹View the logs.


4 years ago

#9 @kraftbj
4 years ago

  • Keywords commit added

Assets added in r18735-dotorg. The CDN is ready: โ€‹https://s.w.org/images/core/emoji/14.0.0/svg/1fae0.svg

#10 @kraftbj
4 years ago

Per feedback in the PR, there is some doubt if using the {right|left}hand in the detection script is proper due to a comment there mentioning that only older emoji should be used.

In the PR, @peterwilsoncc and I agree that we should land this for beta 1, then do intentional testing on older devices/operating systems so any updates can be made during the beta window.

#11 @peterwilsoncc
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53150:

Emoji: Update the Twemoji to version 14.0.2.

This version introduces support for the latest Emoji added in Emoji 14.

"Insert witty comment newly supported emoji."

Props kraftbj, desrosj, dd32, milana_cap.
Fixes #55395.

โ€‹peterwilsoncc commented on โ€‹PR #2416:


4 years ago
#12

Merged in https://core.trac.wordpress.org/changeset/53150, thanks.

I resolved the weird package-lock issue by ignoring the file in this PR and letting NPM do the work.

#13 @dd32
4 years ago

  • Keywords needs-user-docs added; needs-codex removed

#14 @milana_cap
4 years ago

  • Keywords add-to-field-guide added

#15 @kraftbj
4 years ago

  • Keywords commit removed
Note: See TracTickets for help on using tickets.