Make WordPress Core

Opened 22 months ago

Closed 22 months ago

Last modified 22 months ago

#55689 closed feature request (wontfix)

Dashboard welcome-panel image

Reported by: nendeb55's profile nendeb55 Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.0
Component: Help/About Keywords: has-patch dev-feedback
Focuses: Cc:

Description

In WordPress 6.0, the welcome-panel image on the dashboard has the same file name as in 5.9.
When you upgrade from 5.9 to 6.0, if the cache is still there, the 5.9 image will be displayed.

Here is the CSS that is currently in place for the images.

.welcome-panel::before {
    background: url(images/about-header-about.svg) no-repeat center;
}

Attachments (1)

History for wp-admin_images_about-header-about.svg - WordPress_WordPress.png (52.0 KB) - added by mukesh27 22 months ago.

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
22 months ago

  • Component changed from General to Help/About
  • Milestone changed from Awaiting Review to 6.0

This ticket was mentioned in PR #2686 on WordPress/wordpress-develop by audrasjb.


22 months ago
#2

  • Keywords has-patch added

#3 @audrasjb
22 months ago

  • Keywords dev-feedback added

The above PR adds a query var to the URL to try to force cache update for both Welcome Panel CSS images.

#4 @mukesh27
22 months ago

If we add a query in the image URL then we have to add a query string in an older version (5.8, 5.9) also because it uses the same name for those versions.

Please check the attached screenshot.

#5 follow-up: @audrasjb
22 months ago

Hey @mukesh27, could you please explain why you think we would need to add this to older versions? This query parameter is only intended to refresh the cache of the image after updating to the last release. I don't see any benefit in backporting this change to old versions :)

#6 in reply to: ↑ 5 @mukesh27
22 months ago

Replying to audrasjb:

Hey @mukesh27, could you please explain why you think we would need to add this to older versions? This query parameter is only intended to refresh the cache of the image after updating to the last release. I don't see any benefit in backporting this change to old versions :)

As per the ticket comment "When you upgrade from 5.9 to 6.0, if the cache is still there, the 5.9 images will be displayed."

If we upgrade from 5.8 to 5.9 or 6.0, if the cache is still there, the 5.8 images will be displayed because we have the same name image in 5.8

Let me know if I miss understood anything.

#7 @audrasjb
22 months ago

Ok but this would require backporting to previous releases (= release a minor release for those branches). I’m not sure it's worth releasing a new minor release only to address this issue for previous versions :)

#8 @peterwilsoncc
22 months ago

  • Keywords commit added

Linked pull request looks good for commit.

I agree with JB, it's not a big enough issue to warrant back porting to the 5.9 branch and earlier.

#9 @mukesh27
22 months ago

Got it. Thank you for the feedback.

#10 @peterwilsoncc
22 months ago

  • Keywords commit removed
  • Milestone 6.0 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Actually, I've decided to close this as wontfix.

It's a perfectly valid ticket but in another pull request the welcome box will be updated to remove the CSS reference to the images. See PR#2683 for ticket #55532.

This removes both the lines that were to be changed in this ticket so committing the linked PR would simply create merge conflicts for the about page team to deal with.

Note: See TracTickets for help on using tickets.