Dashboard welcome-panel image

[nendeb55]

In WordPress 6.0, the welcome-panel image on the dashboard has the same file name as in 5.9.
When you upgrade from 5.9 to 6.0, if the cache is still there, the 5.9 image will be displayed.

Here is the CSS that is currently in place for the images.

.welcome-panel::before {
    background: url(images/about-header-about.svg) no-repeat center;
}

Trac ticket: https://core.trac.wordpress.org/ticket/55689

[audrasjb]

The above PR adds a query var to the URL to try to force cache update for both Welcome Panel CSS images.

[mukesh27]

If we add a query in the image URL then we have to add a query string in an older version (5.8, 5.9) also because it uses the same name for those versions.

Please check the attached screenshot.

[audrasjb]

Hey @mukesh27, could you please explain why you think we would need to add this to older versions? This query parameter is only intended to refresh the cache of the image after updating to the last release. I don't see any benefit in backporting this change to old versions :)

[mukesh27]

Replying to audrasjb:

Hey @mukesh27, could you please explain why you think we would need to add this to older versions? This query parameter is only intended to refresh the cache of the image after updating to the last release. I don't see any benefit in backporting this change to old versions :)

As per the ticket comment "When you upgrade from 5.9 to 6.0, if the cache is still there, the 5.9 images will be displayed."

If we upgrade from 5.8 to 5.9 or 6.0, if the cache is still there, the 5.8 images will be displayed because we have the same name image in 5.8

Let me know if I miss understood anything.

[audrasjb]

Ok but this would require backporting to previous releases (= release a minor release for those branches). I’m not sure it's worth releasing a new minor release only to address this issue for previous versions :)

[peterwilsoncc]

Linked pull request looks good for commit.

I agree with JB, it's not a big enough issue to warrant back porting to the 5.9 branch and earlier.

[mukesh27]

Got it. Thank you for the feedback.

[peterwilsoncc]

Actually, I've decided to close this as wontfix.

It's a perfectly valid ticket but in another pull request the welcome box will be updated to remove the CSS reference to the images. See ​PR#2683 for ticket #55532.

This removes both the lines that were to be changed in this ticket so committing the linked PR would simply create merge conflicts for the about page team to deal with.

Ticket closed without merge.

Superseded by PR #2683