Opened 2 years ago
Closed 2 years ago
#55808 closed defect (bug) (fixed)
About page: Replace video thumbnail image
Reported by: | critterverse | Owned by: | peterwilsoncc |
---|---|---|---|
Milestone: | 6.0.1 | Priority: | normal |
Severity: | critical | Version: | 6.0 |
Component: | Help/About | Keywords: | has-patch has-testing-info has-screenshots fixed-major |
Focuses: | Cc: |
Description
A placeholder image was accidentally included in the About page for the 6.0 release. We'd like to replace the image with a different thumbnail (that also has a more clear visual indication of the video "play" button).
Attachments (3)
Change History (17)
This ticket was mentioned in Slack in #core by critterverse. View the logs.
2 years ago
This ticket was mentioned in Slack in #core by critterverse. View the logs.
2 years ago
#6
@
2 years ago
- Keywords has-patch has-testing-info has-screenshots added
Patch Report
Patch tested: https://core.trac.wordpress.org/attachment/ticket/55808/55808.2.diff
How to read this report:
🐞 <= Bug occurs.
✅ <= Behavior is expected.
❌ <= Behavior is NOT expected.
Environment
- OS: macOS 12.3.1
- Web Server: Nginx
- macOS 12.3.1
- PHP 7.4.29
- WordPress 6.0.1-alpha-53446-src
- Safari 15.4
Steps to Reproduce
- With WordPress 6.0 or 6.0.1-alpha installed...
- Navigate to
/wp-admin/about.php
. - Scroll to the "Learn more about WordPress 6.1" section.
- 🐞 Notice that the video thumbnail has Anne McCarthy's name listed.
Steps to Test Patch
- 🛠 Apply the patch.
- Refresh the page.
- ✅ Notice that the image has now been updated.
Test Results
- ✅ Issue is reproducible.
- ✅ Issue resolved with patch.
Screenshots
#8
@
2 years ago
I've updated the CDN image url included in 6.0.0 with the correct content, and systems will purge the old version off the CDN.
https://s.w.org/images/core/6.0/about-60-video.png?1 and https://s.w.org/images/core/6.0/about-60-video.png should return the same new image shortly.
Once purged, this ticket should be resolved for all installs.
#9
follow-up:
↓ 10
@
2 years ago
Thanks @dd32, I really appreciate the prompt resolution.
For 6.0.1 it may be worth adding a cache busting query string for any browsers that don't get the HTTP hint to update the cache even though it's likely to affect only a few visitors.
#10
in reply to:
↑ 9
@
2 years ago
Replying to peterwilsoncc:
For 6.0.1 it may be worth adding a cache busting query string for any browsers that don't get the HTTP hint to update the cache even though it's likely to affect only a few visitors.
I do agree, suffixing ?1
or ?2
to the URI should be enough there.
#11
@
2 years ago
Given the CDN has been purged, I've uploaded 55808.3.diff as an alternative with a cache busting version string.
It uses ?ver=6.0
to match the cache busting string added to other about images in [53409] for #55750.
#12
@
2 years ago
55808.3.diff LGTM 👍
#13
@
2 years ago
- Keywords fixed-major added
Committed to trunk in r53447 but trac is having problems displaying it at the time of writing. The change is showing on GitHub.
Help/About: Add cache busting string to video thumbnail.
Append
?ver=6.0
to the image used for linking to the video to break the cache in browsers, proxy servers and on the CDN.
A new version of the image has been uploaded and replaced the file in the original location.
Props annezazu, critterverse, ryelle, costdev, ironprogrammer, dd32.
Fixes #55808.
Marking as fixed major and ready for backport to the 6.0 branch.
Presuming trac behaves at the time, the backport commit will ensure props get applied to this ticket correctly.
The image has been uploaded to the CDN:
https://s.w.org/images/core/6.0/about-60-video-thumbnail.png