Make WordPress Core

Opened 2 years ago

Closed 23 months ago

#55808 closed defect (bug) (fixed)

About page: Replace video thumbnail image

Reported by: critterverse's profile critterverse Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.0.1 Priority: normal
Severity: critical Version: 6.0
Component: Help/About Keywords: has-patch has-testing-info has-screenshots fixed-major
Focuses: Cc:

Description

A placeholder image was accidentally included in the About page for the 6.0 release. We'd like to replace the image with a different thumbnail (that also has a more clear visual indication of the video "play" button).

Attachments (3)

video-thumbnail.png (8.4 KB) - added by critterverse 2 years ago.
55808.2.diff (752 bytes) - added by costdev 2 years ago.
Updated with new image URL.
55808.3.diff (750 bytes) - added by peterwilsoncc 2 years ago.

Download all attachments as: .zip

Change History (17)

#1 @costdev
2 years ago

  • Milestone changed from Awaiting Review to 6.0.1

This ticket was mentioned in Slack in #core by critterverse. View the logs.


2 years ago

#3 @ryelle
2 years ago

The image has been uploaded to the CDN: https://s.w.org/images/core/6.0/about-60-video-thumbnail.png

This ticket was mentioned in Slack in #core by critterverse. View the logs.


2 years ago

@costdev
2 years ago

Updated with new image URL.

#5 @critterverse
2 years ago

Tested and looks good to me. Thanks, all!

#6 @ironprogrammer
2 years ago

  • Keywords has-patch has-testing-info has-screenshots added

Patch Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/55808/55808.2.diff

How to read this report:

🐞 <= Bug occurs.
✅ <= Behavior is expected.
❌ <= Behavior is NOT expected.

Environment

  • OS: macOS 12.3.1
  • Web Server: Nginx
  • macOS 12.3.1
  • PHP 7.4.29
  • WordPress 6.0.1-alpha-53446-src
  • Safari 15.4

Steps to Reproduce

  1. With WordPress 6.0 or 6.0.1-alpha installed...
  2. Navigate to /wp-admin/about.php.
  3. Scroll to the "Learn more about WordPress 6.1" section.
  4. 🐞 Notice that the video thumbnail has Anne McCarthy's name listed.

Steps to Test Patch

  1. 🛠 Apply the patch.
  2. Refresh the page.
  3. ✅ Notice that the image has now been updated.

Test Results

  • ✅ Issue is reproducible.
  • ✅ Issue resolved with patch.

Screenshots

Before patch:
https://cldup.com/t7myt1WRts.png

After patch:
https://cldup.com/4dWzgri5QH.png

#7 @costdev
2 years ago

  • Owner set to peterwilsoncc
  • Status changed from new to assigned

#8 @dd32
2 years ago

I've updated the CDN image url included in 6.0.0 with the correct content, and systems will purge the old version off the CDN.

https://s.w.org/images/core/6.0/about-60-video.png?1 and https://s.w.org/images/core/6.0/about-60-video.png should return the same new image shortly.

Once purged, this ticket should be resolved for all installs.

#9 follow-up: @peterwilsoncc
2 years ago

Thanks @dd32, I really appreciate the prompt resolution.

For 6.0.1 it may be worth adding a cache busting query string for any browsers that don't get the HTTP hint to update the cache even though it's likely to affect only a few visitors.

#10 in reply to: ↑ 9 @dd32
2 years ago

Replying to peterwilsoncc:

For 6.0.1 it may be worth adding a cache busting query string for any browsers that don't get the HTTP hint to update the cache even though it's likely to affect only a few visitors.

I do agree, suffixing ?1 or ?2 to the URI should be enough there.

#11 @peterwilsoncc
2 years ago

Given the CDN has been purged, I've uploaded 55808.3.diff as an alternative with a cache busting version string.

It uses ?ver=6.0 to match the cache busting string added to other about images in [53409] for #55750.

#13 @peterwilsoncc
2 years ago

  • Keywords fixed-major added

Committed to trunk in r53447 but trac is having problems displaying it at the time of writing. The change is showing on GitHub.

Help/About: Add cache busting string to video thumbnail.

Append ?ver=6.0 to the image used for linking to the video to break the cache in browsers, proxy servers and on the CDN.

A new version of the image has been uploaded and replaced the file in the original location.

Props annezazu, critterverse, ryelle, costdev, ironprogrammer, dd32.
Fixes #55808.

Marking as fixed major and ready for backport to the 6.0 branch.

Presuming trac behaves at the time, the backport commit will ensure props get applied to this ticket correctly.

#14 @SergeyBiryukov
23 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53649:

Help/About: Add cache busting string to video thumbnail.

Append ?ver=6.0 to the image used for linking to the video to break the cache in browsers, proxy servers and on the CDN.

A new version of the image has been uploaded and replaced the file in the original location.

Props annezazu, critterverse, ryelle, costdev, ironprogrammer, dd32, peterwilsoncc.
Merges [53447] to the 6.0 branch.
Fixes #55808.

Note: See TracTickets for help on using tickets.