Make WordPress Core

Opened 21 months ago

Closed 17 months ago

Last modified 17 months ago

#56030 closed task (blessed) (fixed)

Update the Underscore library for 6.1

Reported by: desrosj's profile desrosj Owned by: anonymized_20055759's profile anonymized_20055759
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: good-first-bug needs-patch add-to-field-guide
Focuses: Cc:

Description

An update is available for the Underscore library. Core currently bundles 1.13.3.

If additional updates become available prior to 6.1, this ticket can be used to apply them.

Changelog: https://underscorejs.org/#changelog.

Previously: #55547 (6.0).

Change History (16)

This ticket was mentioned in PR #2885 on WordPress/wordpress-develop by christinavoudouris.


20 months ago
#1

  • Keywords has-patch added

Hey all, long time WordPress user here, first time contributing :)

Trac ticket: https://core.trac.wordpress.org/ticket/56030

christinavoudouris commented on PR #2885:


20 months ago
#2

Sorry, there's an old branch called update-package. Closing this.

This ticket was mentioned in PR #2886 on WordPress/wordpress-develop by christinavoudouris.


20 months ago
#3

Hey all, long time WordPress user here, first time contributing :)

Trac ticket: https://core.trac.wordpress.org/ticket/56030

This ticket was mentioned in PR #2887 on WordPress/wordpress-develop by dilipbheda.


20 months ago
#4

I have updated the latest library version in the register script as well.

Trac ticket: https://core.trac.wordpress.org/ticket/56030

#5 follow-up: @dilipbheda
20 months ago

@christinavoudouris,
Your PR looks good, You have missed the updated library version on the register script. I have changed the version and created a new PR.

#6 in reply to: ↑ 5 @anonymized_20055759
20 months ago

Replying to dilipbheda:
Hey, thanks! I didn't know I was supposed to update that file but now I'm learning. I was confused about the merge conflicts occurring and not sure why a few of my packages are different. Let me know if there's something else I should do on my end.

@christinavoudouris,
Your PR looks good, You have missed the updated library version on the register script. I have changed the version and created a new PR.

Last edited 20 months ago by anonymized_20055759 (previous) (diff)

christinavoudouris commented on PR #2885:


20 months ago
#7

<s>Sorry, there's an old branch called update-package.</s> Closing this.

#8 @desrosj
20 months ago

  • Keywords changes-requested added
  • Owner set to christinavoudouris
  • Status changed from new to assigned

@christinavoudouris @dilipbheda Thanks for these PRs! Looks like this is close.

I was confused about the merge conflicts occurring and not sure why a few of my packages are different.

@christinavoudouris I think the merge conflicts are occurring because your fork is a bit outdated. You should be able to use the fetch and merge option when viewing your fork. Then you can recreate your PR, or pull the changes to your fork's trunk branch into your pull request branch.

It looks like both PRs change different files, but all of those changes are needed:

  • package.json
  • package-lock.json
  • script-loader.php

I'm assigning the ticket to you @christinavoudouris as that's the way good-first-bug tickets are marked as claimed.

#9 @anonymized_20055759
20 months ago

Hmm I thought I had grabbed the latest version. I just went back in and updated the packages in package.json that did not line up. Now it's basically telling me there's still a conflict because I'm going from underscore 1.13.3 to 1.13.4 which is exactly what I'm trying to update anyway. I *did* have underscore 1.13.1 when I initially pulled though. Do we want to go to the latest version?

UPDATE: I made a few more commits and it looks like this is ready to be merged, with the latest version of Underscore. Thank you both for your input!

Is there a way to delete PR 2885?

Last edited 20 months ago by anonymized_20055759 (previous) (diff)

#10 @desrosj
20 months ago

  • Keywords commit added; changes-requested removed

Thanks @christinavoudouris! This looks good to go.

#11 @desrosj
20 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 53660:

External Libraries: Update the Underscore library to version 1.13.4.

This is a minor documentation and bug fix release.

Props christinavoudouris, dilipbheda.
Fixes #56030.

#14 @desrosj
17 months ago

  • Keywords needs-patch added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

While updating other dependencies today, I noticed that releasing a 1.13.5 version is in progress. Re-openeing to follow up once the maintainers finish pushing that out.

#15 @desrosj
17 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 54328:

External Libraries: Update Underscore.js to version 1.13.6.

There are no code changes to the library in this release.

Updating to the latest version for WordPress 6.1 ensures security scanners do not incorrectly flag sites as potentially insecure for having out of date libraries.

Fixes #56030.

#16 @milana_cap
17 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.