Update the Underscore library for 6.1

[desrosj]

An update is available for the Underscore library. Core currently bundles 1.13.3.

If additional updates become available prior to 6.1, this ticket can be used to apply them.

Changelog: ​https://underscorejs.org/#changelog.

Previously: #55547 (6.0).

Hey all, long time WordPress user here, first time contributing :)

Trac ticket: https://core.trac.wordpress.org/ticket/56030

Sorry, there's an old branch called update-package. Closing this.

Hey all, long time WordPress user here, first time contributing :)

Trac ticket: https://core.trac.wordpress.org/ticket/56030

I have updated the latest library version in the register script as well.

Trac ticket: https://core.trac.wordpress.org/ticket/56030

[dilipbheda]

@christinavoudouris,
Your PR looks good, You have missed the updated library version on the register script. I have changed the version and created a new PR.

[anonymized_20055759]

Replying to dilipbheda:
Hey, thanks! I didn't know I was supposed to update that file but now I'm learning. I was confused about the merge conflicts occurring and not sure why a few of my packages are different. Let me know if there's something else I should do on my end.

@christinavoudouris,
Your PR looks good, You have missed the updated library version on the register script. I have changed the version and created a new PR.

<s>Sorry, there's an old branch called update-package.</s> Closing this.

[desrosj]

@christinavoudouris @dilipbheda Thanks for these PRs! Looks like this is close.

I was confused about the merge conflicts occurring and not sure why a few of my packages are different.

@christinavoudouris I think the merge conflicts are occurring because your fork is a bit outdated. You should be able to use the ​fetch and merge option when viewing your fork. Then you can recreate your PR, or pull the changes to your fork's trunk branch into your pull request branch.

It looks like both PRs change different files, but all of those changes are needed:

• package.json
• package-lock.json
• script-loader.php

I'm assigning the ticket to you @christinavoudouris as that's the way good-first-bug tickets are marked as claimed.

[anonymized_20055759]

Hmm I thought I had grabbed the latest version. I just went back in and updated the packages in package.json that did not line up. Now it's basically telling me there's still a conflict because I'm going from underscore 1.13.3 to 1.13.4 which is exactly what I'm trying to update anyway. I *did* have underscore 1.13.1 when I initially pulled though. Do we want to go to the latest version?

UPDATE: I made a few more commits and it looks like this is ready to be merged, with the latest version of Underscore. Thank you both for your input!

Is there a way to delete PR 2885?

[desrosj]

Thanks @christinavoudouris! This looks good to go.

[desrosj]

In 53660:

External Libraries: Update the Underscore library to version 1.13.4.

This is a minor documentation and bug fix release.

Props christinavoudouris, dilipbheda.
Fixes #56030.

Fixed in https://core.trac.wordpress.org/changeset/53660.

Merged in https://core.trac.wordpress.org/changeset/53660.

[desrosj]

While updating other dependencies today, I noticed that releasing a 1.13.5 version is in progress. Re-openeing to follow up once the maintainers finish pushing that out.

[desrosj]

In 54328:

External Libraries: Update Underscore.js to version 1.13.6.

There are no code changes to the library in this release.

Updating to the latest version for WordPress 6.1 ensures security scanners do not incorrectly flag sites as potentially insecure for having out of date libraries.

Fixes #56030.