WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#5607 closed defect (bug) (fixed)

Fix PHP Notices in admin

Reported by: filosofo Owned by: westi
Milestone: 2.6 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords:
Focuses: Cc:

Description

Ah, the joys of having WP_DEBUG set to "true."

Attachments (16)

remove_admin_notices.diff (2.1 KB) - added by filosofo 10 years ago.
remove_admin_notices2.diff (1.6 KB) - added by filosofo 10 years ago.
remove_admin_notices3.diff (2.2 KB) - added by filosofo 10 years ago.
remove_admin_notices4.diff (1.4 KB) - added by filosofo 10 years ago.
remove_admin_notices5.diff (4.2 KB) - added by filosofo 10 years ago.
remove_admin_notices6.diff (2.4 KB) - added by filosofo 10 years ago.
remove_admin_notices7.diff (4.0 KB) - added by filosofo 10 years ago.
remove_admin_notices8.diff (2.0 KB) - added by filosofo 10 years ago.
remove_admin_notices9.diff (2.6 KB) - added by filosofo 10 years ago.
remove_admin_notices10.diff (1.8 KB) - added by filosofo 10 years ago.
remove_admin_notices11.diff (4.7 KB) - added by filosofo 10 years ago.
remove_admin_notices12.diff (5.8 KB) - added by filosofo 10 years ago.
remove_admin_notices13.diff (2.2 KB) - added by filosofo 10 years ago.
remove_admin_notices14.diff (3.8 KB) - added by filosofo 10 years ago.
remove_admin_notices15.diff (1.7 KB) - added by filosofo 10 years ago.
remaining_notices.diff (29.8 KB) - added by westi 10 years ago.
Merged patch for wp-admin remaining notices

Download all attachments as: .zip

Change History (23)

#1 @westi
10 years ago

  • Owner changed from anonymous to westi
  • Status changed from new to assigned

Thank you for the patch!

From a quick look through I am not sure that 100% of the changes are the best fix.

I will go through and review and commit soon.

#2 @filosofo
10 years ago

Sorry for so many patches, but I couldn't get a clean diff with a large patch.

What are some examples of problems with the changes?

#3 @westi
10 years ago

(In [6592]) Notice fixing for wp-includes. See #5607 props filosofo.

@westi
10 years ago

Merged patch for wp-admin remaining notices

#4 @westi
10 years ago

Ok wp-includes changes reviewed and some modifications made.

Patch for just the wp-admin changes uploaded - will review when I have some more time.

#5 @jacobsantos
10 years ago

  • Milestone changed from 2.9 to 2.6.1
  • Resolution set to fixed
  • Status changed from assigned to closed

I think there should only be one ticket for notices and warnings fixes per WordPress version. Closing as fixed. A new ticket should be created for 2.7, 2.8, etc.

#6 @jacobsantos
10 years ago

  • Keywords has-patch removed

#7 @ryan
10 years ago

  • Milestone changed from 2.6.1 to 2.6
Note: See TracTickets for help on using tickets.