Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#56108 closed defect (bug) (fixed)

Wrong escaping in admin menu walker file

Reported by: aniketpatel's profile aniketpatel Owned by: audrasjb's profile audrasjb
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch commit
Focuses: Cc:


We have found one escaping error in class-walker-nav-menu-edit.php admin file and attach patch for this bug.

Attachments (1)

56108.patch (752 bytes) - added by aniketpatel 2 years ago.

Download all attachments as: .zip

Change History (7)

2 years ago

#1 @audrasjb
2 years ago

  • Component changed from Administration to Menus
  • Milestone changed from Awaiting Review to 6.1
  • Owner set to audrasjb
  • Status changed from new to reviewing

Thanks for opening this ticket and for the patch.

The patch looks good to me at a glance.
Moving for 6.1 consideration.

#3 @audrasjb
2 years ago

Added a PR to refresh the patch and make sure it passes unit tests.

#4 @audrasjb
2 years ago

  • Keywords commit added

Looks good to go.

#5 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 53654:

Menus: Use more appropriate escaping functions in class Walker_Nav_Menu_Edit.

This changeset replaces esc_attr escaping function with esc_url as it is more appropriate in the context of a link's href attribute.

Props audrasjb, aniketpatel.
Fixes #56108.

Note: See TracTickets for help on using tickets.