Make WordPress Core

Opened 4 years ago

Closed 8 months ago

#56188 closed defect (bug) (duplicate)

Attempt to read property "post_type" on null after PHP 8.1

Reported by: brmartinez's profile brmartinez Owned by:
Milestone: Priority: normal
Severity: critical Version:
Component: Posts, Post Types Keywords: has-patch has-unit-tests
Focuses: Cc:

Description (last modified by sabernhardt)

Hello, I've noticed this error in WordPress since I've installed PHP 8.1. Can you fix it?

[09-Jul-2022 16:16:45 UTC] PHP Warning: Attempt to read property "post_type" on null in /.../wp-includes/class-wp-query.php on line 4338

Change History (6)

This ticket was mentioned in PR #3142 on WordPress/wordpress-develop by Tabrisrp.


3 years ago
#1

  • Keywords has-patch added; needs-patch removed

get_queried_object() can return null, but there was no check for its value before trying to read the post_type property from the value.

Trac ticket: https://core.trac.wordpress.org/ticket/56188

jrfnl commented on PR #3142:


3 years ago
#2

Please add a test covering this change.

#3 @tabrisrp
3 years ago

  • Keywords has-unit-tests added

#4 @dd32
3 years ago

#56714 was marked as a duplicate.

#5 @dd32
3 years ago

This is also being tracked via #29660

#6 @sabernhardt
8 months ago

  • Description modified (diff)
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #29660.

[54496] edited several query functions to prevent PHP warnings like this.

Note: See TracTickets for help on using tickets.