WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#56319 closed defect (bug) (fixed)

Update mediaelement.js to version 4.2.17

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: good-first-bug changes-requested has-patch add-to-field-guide
Focuses: Cc:

Description

Since the last update to mediaelement was applied in [49070], several new versions have been released.

The latest versions (5.x+) have potentially breaking changes that will need to be tested in more detail, and potentially be accompanied with more communication to plugin and theme developers.

In the short term, the ​4.2.17 bug fix release should be merged into Core.

Attachments (1)

mediaelement.patch​ (656.5 KB) - added by cdbessig 3 years ago.

Download all attachments as: .zip

Change History (10)

#1 @desrosj
3 years ago

Related: #56320.

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
3 years ago

@cdbessig
3 years ago

#3 @desrosj
3 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#4 @desrosj
3 years ago

  • Keywords needs-refresh added

Thanks for the patch @cdbessig!

Could you share a bit about how you created it? There seem to be a few issues:

  • It looks like the lang/* and renderers/* files are marked for deletion, but these are not included in WordPress (with the exception of the Vimeo renderer).
  • It looks like mediaelement.js was updated to 4.2.16, but then the patch is downgrading it back to 4.2.16 (the current version in WP).

Would you be able to refresh the patch so this can be included in WP 6.1?

#5 @desrosj
2 years ago

  • Keywords changes-requested has-patch added; needs-patch needs-refresh removed

#7 @desrosj
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54354:

External Libraries: Update MediaElement.js to version 4.2.17.

This is a minor bug fix release and the latest in the 4.x branch.

A full list of changes can be found on the library’s GitHub: ​https://github.com/mediaelement/mediaelement/releases/tag/4.2.17.

While this is not the latest version (the 5.x branch is), further testing needs to be done to confirm compatibility in WordPress. #56320 has been opened to explore this.

Props cdbessig, desrosj.
Fixes #56319.

#9 @milana_cap
2 years ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.