#56366 closed defect (bug) (fixed)
Twenty Twenty-One: Consider removing `.woocommerce` class from theme styles
Reported by: | sabernhardt | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch has-screenshots commit |
Focuses: | css | Cc: |
Description
The selectors for Twenty Twenty-One's default max-width
have used the .woocommerce
class since the theme's initial commit.
Current:
.entry-content > *:not(.alignwide):not(.alignfull):not(.alignleft):not(.alignright):not(.wp-block-separator):not(.woocommerce), *[class*="inner-container"] > *:not(.entry-content):not(.alignwide):not(.alignfull):not(.alignleft):not(.alignright):not(.wp-block-separator):not(.woocommerce) {
@davidbaumwald stated in ticket:56337#comment:11:
I don't think Core should have that code as it would need to be supported forever. This gets worse as WC evolves and changes its code which then requires more adjustments by Core.
Attachments (2)
Change History (12)
#3
@
2 years ago
- Keywords has-patch added
This CSS style is reflected in the Cart and Checkout page. There is already a separate style for the twenty-twenty-one theme set from Woocommerce which overrides the current .entry-content
style, so removing :not(.woocommerce)
from the selectors doesn't have any effects on the existing styles. Here is a screenshot - https://prnt.sc/6IvB9C-zBanA
#5
@
2 years ago
- Owner set to audrasjb
- Status changed from new to accepted
Looks good to me, thanks for the ping.
Self assigning for final testing and commit.
This ticket was mentioned in PR #3252 on WordPress/wordpress-develop by audrasjb.
2 years ago
#7
Trac ticket: https://core.trac.wordpress.org/ticket/56366
2 years ago
#10
Committed in https://core.trac.wordpress.org/changeset/54170
Moving for 6.1 consideration.