Opened 4 years ago
Closed 4 years ago
#56396 closed defect (bug) (fixed)
Twenty Twenty: update selectors in get_non_latin_css()
| Reported by: | sabernhardt | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.1 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch has-screenshots commit |
| Cc: | Focuses: | css |
Description
Several of the selectors used to set fonts are missing from the 'front-end' array:
.faux-button.more-link, .entry-content .wp-block-cover-image p, .entry-content, .entry-content h1, .entry-content h2, .entry-content h3, .entry-content h4, .entry-content h5, .entry-content h6, .entry-content table, .entry-content address, .entry-content .wp-block-file
As a result, elements such as headings in the post content have the default sans-serif font (Inter variable or a system font) instead of the one defined for the language. Likewise, some elements in .entry-content would still display in a serif font.
The 'block-editor' and 'classic-editor' arrays may need updating as well (beyond removing .wp-block from headings in #56194). A comparison spreadsheet shows selectors from all three arrays against similar selectors in style.css.
Reviewing the languages would be good, too. For example, Persian (fa-IR) is included, but not the Afghanistan fa-AF locale.
Attachments (4)
Change History (10)
#1
@
4 years ago
- Keywords has-patch added
In 56396.diff, I did not remove any selectors that are not used for fonts in style.css, such as .entry-content p.
#2
@
4 years ago
- Keywords has-screenshots added
- Owner set to
- Status new → accepted
Thanks @sabernhardt! The patch fixes the issue on my side.
#3
@
4 years ago
@sabernhardt I'm wondering if we should separate the two part of this ticket: ship the selector change, but open a new ticket for the missing languages. Any thought?
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
add missing selectors (only)