Twenty Nineteen: Text Color issue in Pullquote Block

[kajalgohel]

In Twenty Nineteen Theme, when we add Pullquote block in editor side, and choose text color, We can see that the text color is not reflected for "Add citation" text.But when we see the same Pullquote block at front side, text color for "Add quote" and "Add citation" is not reflected.

Steps to replicate:
1: Activate the Twenty Nineteen Theme
2: Add Pullquote block
3: Enter some Text for "Add quote"
4: Enter some Text for "Add citation"
3: Choose Text color
4: Save Page/Post
5: View the page/post at front side

For better understanding I provide video attachment link.
Video URL : ​https://share.cleanshot.com/4DhJNFXRZcP8DJKYfZnp

Thanks

[varshil151189]

Added Patch for “Add quote” text color.

[kmadhak]

added patch for “Add quote” text color and also changed in RTL file

[poena]

#60797 was marked as a duplicate.

[karmatosed]

Moving to next release as potential if we can get some testing.

[krupajnanda]

Test Report

Description

This report validates that the indicated patch does not work as expected. ❌
I don't see any change as requested.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/56455/%2356455.patch

Environment

• WordPress: 6.6-beta2-58392-src
• PHP: 8.2.15
• Server: nginx/1.25.3
• Database: mysqli (Server: 8.0.36 / Client: mysqlnd 8.2.15)
• Browser: Chrome 125.0.0.0
• OS: macOS
• Theme: Twenty Nineteen 2.8
• MU Plugins:
  • Safe Autoloaded Options Limit Test (MU Plugin) 1.0
• Plugins:
  • Test Reports 1.1.0

Test Steps:

1. Apply the patch
2. Activate the Twenty Nineteen Theme in your local setup
3. Add a new Post/Page
4. Add Pullquote block
5. Enter some Text for "Add quote"
6. Enter some Text for "Add citation"
7. Choose Text color and observe that the color isn't getting changed for citation text.
8. Save Page/Post
9. View the page/post at front side
10. Observe that the issue still persists!

Actual Results

1. Issue does not resolve with patch. ❌

Supplemental Artifacts

Add as Attachment

[karmatosed]

Let's move this out of this release as we likely need a patch refresh based on testing.

[karmatosed]

Noting with the keywords this needs a refresh.

Trac ticket: https://core.trac.wordpress.org/ticket/56455

[sainathpoojary]

I tested the patch from this ​pull request, and it works correctly when only the text color is changed. However, when both the background color and text color are applied together, there is an inconsistency between the frontend and the editor.

When only the text color is changed:

When the background color is combined with the text color:

[poena]

There are now 3 tickets open for the same issue, I feel strongly that we need to continue working together on one ticket.

PR 8018 is the most complete patch submitted for the three tickets so far, because it updates the files correctly using SASS.

I want to make the following change requests:

The default color of the pullquote text and cite must remain the same.
The original theme design should be kept unless there are no other options than to change it.
Changing the default would be an unexpected change on existing websites, and that needs to be weighed in.

The CSS variable should not be removed from the cite, because there are child themes that take advantage of updating the CSS variables with their own custom colors.
If that color was not used anymore it would be a breaking changes, it should be avoided unless there are no other options.

Like @sainathpoojary showed, the theme has a built-in color contrast feature that sets an accessible text color when the background color is changed to a color from the theme palette. The text color change should only happen when the user has not selected a text color.