rest_get_route_for_post missing usages in Posts Controller prepare_links method

[get_dave]

Whilst working on ​https://github.com/WordPress/gutenberg/pull/42809#issuecomment-1231875463 we discovered that the function [rest_get_route_for_post](​https://developer.wordpress.org/reference/functions/rest_get_route_for_post/) isn't fully implemented within the WP_REST_Posts_Controller.

As this function is filterable this can lead to inconsistencies.

​https://developer.wordpress.org/reference/hooks/rest_route_for_post/

To quote:

The rest_get_route_for_post function is filterable. So it can be modified to use the slug instead of the id. But it looks like we missed some spots when implementing rest_get_route_for_post, like in prepare_links, so that will need to be addressed in a Core ticket.

Examples include:

• ​https://github.com/WordPress/wordpress-develop/blob/97218bbfd336035edc9293274fea0f7bd3da85d7/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L1991
• ​https://github.com/WordPress/wordpress-develop/blob/97218bbfd336035edc9293274fea0f7bd3da85d7/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L2024
• ​https://github.com/WordPress/wordpress-develop/blob/97218bbfd336035edc9293274fea0f7bd3da85d7/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php#L2032

Trac ticket: https://core.trac.wordpress.org/ticket/56472

@getdave Can you take a look

[get_dave]

I tested this by checking out ​https://github.com/WordPress/gutenberg/pull/42809/ which modifies the route for wp_navigation. I then made a REST for a single Navigation post by slug.

I received the following which indicates that these changes are 👍

@getdave Do you want this in 6.0.x?

@getdave Do you want this in 6.0.x?

I think it would be fine for 6.1.

@TimothyBJacobs Can you take a look a this please. Happy to commit.

I'm also seing usages in WP_REST_Posts_Controller::create_item for the Location header. We can also use rest_get_route_for_post_type_items in WP_REST_Posts_Controller::get_items when preparing the pagination links.

[SergeyBiryukov]

Hi there, thanks for the ticket!

Reopening, as it looks like the PR has not been committed yet, so the closing in comment:4 appears to be unintentional.

See ​The Bug Tracker (Trac) for ticket resolution descriptions:

worksforme: The bug reported in the ticket cannot be reproduced. Sometimes, an existing plugin, hook, or feature may render the ticket moot, so the ticket can be closed without further action.

[TimothyBlynJacobs]

In 54121:

REST API: Use helper functions for building routes in more places.

Props get_dave, spacedmonkey.
Fixes #56472.

Merged in da03cf1c6b3ab71ea7e56f4a050d87c41150726e.