#56474 closed defect (bug) (fixed)
Twenty Twenty: Fix social icons margin in widget area
Reported by: | grandeljay | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | 5.9 |
Component: | Bundled Theme | Keywords: | has-patch has-screenshots commit |
Focuses: | css | Cc: |
Description
Attachments (5)
Change History (14)
This ticket was mentioned in PR #3159 on WordPress/wordpress-develop by grandeljay.
2 years ago
#1
This ticket was mentioned in PR #3159 on WordPress/wordpress-develop by grandeljay.
2 years ago
#2
This is supposed to fix the margin on the social icons in the footer widget for Twenty Twenty
Trac ticket: https://core.trac.wordpress.org/ticket/56474
#3
@
2 years ago
- Component changed from Themes to Bundled Theme
- Focuses css added
- Milestone changed from Awaiting Review to 6.1
- Severity changed from trivial to normal
- Summary changed from Twenty Twenty: Fix social icons margin to Twenty Twenty: Fix social icons margin in widget area
- Version trunk deleted
Thanks for the report and the patch!
If someone has customized the margin for li
elements in other widget blocks, adding :not()
to the theme's .widget li
selector would override their custom margin.
Adding something like this in a new "Widget: Blocks" sub-section (perhaps following "Widget: Text" under "Widgets") might be better:
.widget .wp-block-social-links li { margin-top: 0; }
#4
@
2 years ago
- Version set to 5.9
Before 5.9, the block-library stylesheet set the margins for these icons, and that had higher specificity than .widget li
:
.wp-block-social-links .wp-social-link.wp-social-link.wp-social-link { margin: 4px 8px 4px 0; }
#5
@
2 years ago
Thanks!
I've changed the selector to .widget .wp-block-social-links li
now and it seems to display properly.
#6
@
2 years ago
The top margin on .widget li
was in the theme early (and increased before the theme became available), so I think that needs to stay.
56474.diff removes the top margin from social icons in a widget area, without affecting other list widgets.
#7
@
2 years ago
- Keywords has-screenshots commit added
- Owner set to audrasjb
- Status changed from new to accepted
Thanks for the patch and for testing so much use cases @sabernhardt!
I added my own test results and it works fine. Self assigning for commit
.
This is supposed to fix the margin on the social icons in the footer widget for Twenty Twenty
Trac ticket: https://core.trac.wordpress.org/ticket/56474