WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 15 months ago

#56603 closed defect (bug) (fixed)

Twenty Ten: Heading Block Text color not reflected in Front side

Reported by: umesh84's profile umesh84 Owned by: audrasjb's profile audrasjb
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-screenshots commit
Focuses: ui, css Cc:

Description (last modified by sabernhardt)

In the Theme Twenty Ten Heading Block Text color not reflected in Front side

  1. Activate the Twenty Ten Themes
  2. Add Heading Block
  3. Change Text color
  4. See issue

For better understanding I provide video attachment link.
URL: ​https://www.loom.com/share/81aa30b1acf3441994c6abf25989de5f

Attachments (4)

56603.patch​ (1.9 KB) - added by umesh84 2 years ago.
added patch
56603.1.patch​ (1.3 KB) - added by sabernhardt 2 years ago.
adding #content to text color selectors, while keeping the original selectors (so the colors can work in widgets)
Capture d’écran 2023-06-28 à 00.19.59.png​ (231.6 KB) - added by audrasjb 15 months ago.
Before patch: colors not applied :'(
Capture d’écran 2023-06-28 à 00.23.16.png​ (198.8 KB) - added by audrasjb 15 months ago.
After patch: colored! \o/

Download all attachments as: .zip

Change History (13)

@umesh84
2 years ago

added patch

#1 @umesh84
2 years ago

  • Keywords has-patch added; needs-patch removed

@sabernhardt
2 years ago

adding #content to text color selectors, while keeping the original selectors (so the colors can work in widgets)

#2 @sabernhardt
2 years ago

  • Description modified (diff)

The color classes should stay so that they apply outside the main content area. Also, the background color classes seem to work without adding #content.

#3 @sabernhardt
2 years ago

  • Summary changed from Theme Twenty Ten Heading Block Text color not reflected in Front side to Twenty Ten: Heading Block Text color not reflected in Front side

#4 @pooja1210
16 months ago

Hi,

Patch report for - https://core.trac.wordpress.org/attachment/ticket/56603/56603.1.patch

Environment:
WordPress: v6.2.2
Theme: Twenty Ten
OS: Mac
Browser: Chrome

Steps to reproduce:

  1. Activate the Twenty Ten theme
  2. Add the Page/Post.
  3. Add Heading Block
  4. Change Text color
  5. Click on Preview See issue

Before Screenshots:
Backend - ​https://prnt.sc/HDZJCA7g5KqQ
Frontend - ​https://prnt.sc/oUjWCM5QMztX

After Screenshots:
Backend - ​https://prnt.sc/HDZJCA7g5KqQ
Frontend - ​https://prnt.sc/E3PJv9--Tdwb

The patch is working as expected.

Thanks!

#5 @sabernhardt
16 months ago

  • Milestone changed from Awaiting Review to 6.3

#6 @darshitrajyaguru97
15 months ago

  • Keywords has-screenshots added

Hi,

Patch report for - https://core.trac.wordpress.org/attachment/ticket/56603/56603.1.patch

Environment:

  • WordPress: v6.2.2
  • Theme: Twenty Ten
  • OS: Windows
  • Browser: Chrome

Steps to reproduce:

  • Activate the Twenty Ten theme
  • Add the Page/Post.
  • Add Heading Block
  • Change Text color
  • Click on Preview See issue

Backend: ​https://prnt.sc/oAdfwufhv6Qv

Frontend:
Before Patch Frontend - ​https://prnt.sc/f3JrUt_ec-yh
After Patch Frontend - ​https://prnt.sc/LE_5etp9r8uR

https://core.trac.wordpress.org/attachment/ticket/56603/56603.1.patch is working as expected.

Thanks!

Last edited 15 months ago by darshitrajyaguru97 (previous) (diff)

#7 @audrasjb
15 months ago

  • Keywords needs-testing removed
  • Owner set to audrasjb
  • Status changed from new to reviewing
  • Version 6.0.2 deleted

@audrasjb
15 months ago

Before patch: colors not applied :'(

@audrasjb
15 months ago

After patch: colored! \o/

#8 @audrasjb
15 months ago

  • Keywords commit added
  • Status changed from reviewing to accepted

Ready to ship!

#9 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 56080:

Twenty Ten: Reflect Heading block text color on front-end.

This changeset fixes an issue where the selected text color of the Heading block was not reflected on front-end.

Props umesh84, sabernhardt, audrasjb, pooja1210, darshitrajyaguru97.
Fixes #56603.

Note: See TracTickets for help on using tickets.