Make WordPress Core

Opened 19 months ago

Last modified 16 months ago

#56897 new enhancement

First time contributor welcome message improvements

Reported by: desrosj's profile desrosj Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

When a contributor opens a pull request to WordPress/wordpress-develop on GitHub and has not done so before, a comment is left on the PR with some helpful information. Here's an example of the comment's current contents.

Hi @USERNAME! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

- PHP Coding Standards
- CSS Coding Standards
- HTML Coding Standards
- JavaScript Coding Standards
- Accessibility Coding Standards
- Inline Documentation Standards

Thank you,
The WordPress Project

There are a few things missing that should be added:

  • The project's Responsible Disclosure policy for security vulnerabilities should be detailed. This would also be good to add to the pull_request_template.md file to make sure contributors are aware of the policy before publishing the PR.
  • The contributor should be informed that they need to link their WordPress.org account to their GitHub account to receive proper credit for their contribution.

Change History (9)

#2 @desrosj
19 months ago

Another improvement to make: There's no link back to the Core Handbook page about using GH PRs for code reviews: https://make.wordpress.org/core/handbook/contribute/git/github-pull-requests-for-code-review/.

@desrosj commented on PR #3518:


19 months ago
#3

Thanks @peterwilsoncc. This is a good suggestion.

I've created Trac-56897 for tracking this and a few other improvements that have been in the back of my mind lately.

This ticket was mentioned in Slack in #core by costdev. View the logs.


16 months ago

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


16 months ago

#6 @mukesh27
16 months ago

This ticket was discussed in the recent bug scrub.

@peterwilsoncc Is the PR ready for review or is there still some work to be done?

Props to @costdev

#7 @peterwilsoncc
16 months ago

@mukesh27 Still a little work. It might need a documentation change per @desrosj's comment on the ticket.

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


16 months ago

#9 @mukesh27
16 months ago

  • Milestone changed from 6.2 to Future Release

Thanks @desrosj for the ticket.

This ticket was discussed during the bug scrub. As this ticket still needs some work and 6.2 Beta 1 is being released today, I'll move this to Future Release.

Additional props: @costdev

Note: See TracTickets for help on using tickets.