WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57082 closed enhancement (fixed)

Document the globals in various functions

Reported by: krunal265 Owned by: SergeyBiryukov
Priority: normal Milestone: 6.2
Component: General Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

Comment on some functions that need to be improved. In the comment, need to mention the global variable that is used in the function.

Files:
1) wp-admin/includes/post.php

function name: the_block_editor_meta_boxes()

2) wp-includes/block-template-utils.php

function name: wp_generate_block_templates_export_file()

3) wp-includes/class-wp-oembed-controller.php

function name: get_proxy_item()

Attachments (1)

57082.patch​ (1.6 KB ) - added by krunal265 4 years ago.
Patch added

Download all attachments as: .zip

Change History (6)

@krunal265
4 years ago

Patch added

#1 @krunal265
4 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review → 6.2

#3 @SergeyBiryukov
4 years ago

Thanks for the patch!

#4 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 54831:

Docs: Document the usage of globals in some functions.

This affects:

  • the_block_editor_meta_boxes()
  • wp_generate_block_templates_export_file()
  • WP_oEmbed_Controller::get_proxy_item()

Follow-up to [44131], [48135], [51151], [53129].

Props krunal265.
Fixes #57082.

#5 @SergeyBiryukov
4 years ago

  • Summary Comment on some functions needs to be improved → Document the globals in various functions
Note: See TracTickets for help on using tickets.