WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 23 months ago

#57096 closed defect (bug) (invalid)

Post Featured Image - Link settings

Reported by: dhrumilk's profile dhrumilk Owned by:
Milestone: Priority: normal
Severity: blocker Version: 6.1.1
Component: Editor Keywords: has-patch
Focuses: administration, coding-standards Cc:

Description

I have found the bug on the Post Featured Image block. i have use that block on site and set the image on features image block and also add LINK REL and test it but this link is not working on block, link redirect on same post URL, not on set URL.

Screen Shot 1:​https://www.awesomescreenshot.com/image/34351166?key=fd7b17cff868460301b077536890fbee

Screen Shot 2: ​https://www.awesomescreenshot.com/image/34350981?key=f9b55d9078ee5b9659a6aba7c5a0ba1e

Attachments (4)

image-1.png​ (208.6 KB) - added by dhrumilk 2 years ago.
Screenshot 1
image-2.png​ (230.9 KB) - added by dhrumilk 2 years ago.
Screenshot 2
57096.diff​ (711 bytes) - added by dhrumilk 2 years ago.
57096.1.diff​ (710 bytes) - added by dhrumilk 2 years ago.
Updated diff.

Download all attachments as: .zip

Change History (13)

This ticket was mentioned in ​PR #3613 on ​WordPress/wordpress-develop by ​dhrumilkumbhani.
2 years ago #1

  • Keywords has-patch added; needs-patch removed

I have update the code for set the LINK REL value on the Post Featured Image block.

Trac ticket:

#2 @dhrumilk
2 years ago

  • Keywords needs-testing has-patch removed

@dhrumilk
2 years ago

Screenshot 1

@dhrumilk
2 years ago

Screenshot 2

#3 @dhrumilk
2 years ago

  • Keywords close added
  • Resolution set to invalid
  • Status changed from new to closed

I have checked but now it's working perfectly.

#4 @desrosj
2 years ago

  • Component changed from General to Editor
  • Keywords close removed
  • Milestone Awaiting Review deleted

#5 @dhrumilk
2 years ago

  • Focuses accessibility removed
  • Resolution invalid deleted
  • Status changed from closed to reopened
  • Version changed from 6.1 to 6.1.1

This issue is still there.

@dhrumilk
2 years ago

#6 @dhrumilk
2 years ago

  • Keywords has-patch added

#7 @jrf
2 years ago

I haven't checked the issue or the actual correctness of the proposed solution, but would like to note that in the current patch esc_attr() is the wrong escaping function. As this should be a URL, esc_url() should be used.

#8 @dhrumilk
2 years ago

@jrf thank you for the correct me.

@dhrumilk
2 years ago

Updated diff.

#9 @dhrumilk
23 months ago

  • Resolution set to invalid
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.