#57171 closed defect (bug) (fixed)
unit test for wp_filesize()
Reported by: | pbearne | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
Change History (8)
This ticket was mentioned in PR #3660 on WordPress/wordpress-develop by @pbearne.
2 years ago
#1
- Keywords has-patch has-unit-tests added
@spacedmonkey commented on PR #3660:
2 years ago
#3
There were unit tests in the original PR - https://github.com/WordPress/wordpress-develop/pull/2367/files#diff-032b8ca66e0285a30919e60d55165db1e4ab54666b9012512f9e003ca9e07b84
I may have forgotten to commit these 😮💨
@SergeyBiryukov
#5
@
2 years ago
- Milestone changed from Awaiting Review to 6.2
- Owner set to SergeyBiryukov
- Status changed from new to accepted
@SergeyBiryukov commented on PR #3660:
2 years ago
#6
Thanks for the PR!
It looks like there were some pre-existing tests for this function added in r52837 and moved to a separate file in r54861.
Keeping the ticket open for now to see if anything from this PR should be added to the existing tests (though at a glance it seems like they are mostly the same), as well as to commit some other tests pointed out above.
Trac ticket: https://core.trac.wordpress.org/ticket/57171