Make WordPress Core

Opened 4 years ago

Last modified 3 years ago

#57537 new enhancement

Site editor theme export: remove site specific details

Reported by: jffng Owned by:
Priority: normal Milestone: Awaiting Review
Component: General Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

Currently when you use the Site Editor's theme export functionality, there are some block attributes that are specific to the site, including:

  • refs id on the Navigation block
  • queryId on the query block

It would be better to not include these attributes on theme export, since they do not have any use / may cause incorrect behavior if the theme is installed on a different site.

See ​https://github.com/WordPress/gutenberg/issues/42730 for more context.

Change History (4)

This ticket was mentioned in ​PR #3899 on ​WordPress/wordpress-develop by ​@jffng.


4 years ago
#1

  • Keywords has-patch added

​@mikachan commented on ​PR #3899:


4 years ago
#2

Thanks so much for working on this, it looks great!

Do you think we should also remove the id attributes from the image and cover blocks? Both these blocks also include wp-image-[id] classes, which I think would be good to remove at the same time.

​@jffng commented on ​PR #3899:


4 years ago
#3

Do you think we should also remove the id attributes from the image and cover blocks?

Good idea, done in ​4def221. I also added a filter for the media & text block.

​@madhudollu commented on ​PR #3899:


3 years ago
#4

Lets remove taxQuery?
Here is a reference about issue with this attribute p1686029927912499-slack-CRWCHQGUB

Note: See TracTickets for help on using tickets.