Make WordPress Core

Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#57602 closed enhancement (fixed)

Add missing controls to flex layouts

Reported by: isabel_brison's profile isabel_brison Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.2 Priority: normal
Severity: normal Version: 5.9
Component: Editor Keywords: gutenberg-merge has-patch commit
Focuses: Cc:

Description (last modified by hellofromTonya)

Adds missing controls to flex layouts in wp_get_layout_style() for justify-content and vertical alignment options.

Reference:

Change History (6)

This ticket was mentioned in PR #3962 on WordPress/wordpress-develop by @isabel_brison.


17 months ago
#1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/57602

Backports changes from https://github.com/WordPress/gutenberg/pull/47134.

Can be tested manually by adding the following markup to a post, saving and viewing in the front end. All Row children should have the same height.

<div class="wp-block-group">
<p class="has-luminous-vivid-amber-background-color has-background">1 </p>



<p class="has-luminous-vivid-amber-background-color has-background">2</p>



<p class="has-luminous-vivid-amber-background-color has-background">Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
</div>

#2 @hellofromTonya
17 months ago

  • Description modified (diff)
  • Owner set to hellofromTonya
  • Status changed from new to reviewing

Currently reviewing for commit.

#3 @hellofromTonya
17 months ago

  • Keywords commit added
  • Confirmed this PR includes the PHP code changes from the GB PR ✅
  • The sample test code does render all to the same height ✅

PR 3962 is ready for commit 👍

@hellofromTonya commented on PR #3962:


17 months ago
#4

Committing this now.

#5 @hellofromTonya
17 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55201:

Editor: Add missing controls to flex layouts in wp_get_layout_style().

Adds missing controls to flex layouts in wp_get_layout_style() for justify-content and vertical alignment options.

References:

Follow-up to [54274].

Props isabel_brison, andrewserong, jameskoster, joen, onemaggie , ndiego.
Fixes #57602.

Note: See TracTickets for help on using tickets.