Make WordPress Core

Opened 15 months ago

Closed 15 months ago

Last modified 12 months ago

#57608 closed defect (bug) (fixed)

Help tab, says […] Update Media […], while button says Update

Reported by: kebbet's profile kebbet Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch has-screenshots commit
Focuses: ui-copy Cc:

Description

Found while editing an attachment:

The help tab text says:
Remember to click Update Media to save metadata entered or changed.

The primary button on the screen says Update.

The string is found in both wp-admin/media.php and wp-admin/edit-form-advanced.php.
I suggest a change to just Update in both places.

Change History (12)

#1 @costdev
15 months ago

  • Milestone changed from Awaiting Review to 6.2

Hi @kebbet, thanks for opening this ticket! I agree, let's make this consistent.

Milestoning for 6.2 as it's likely to be a very quick change.

This ticket was mentioned in PR #3966 on WordPress/wordpress-develop by @kebbet.


15 months ago
#2

  • Keywords has-patch added; needs-patch removed

@kebbet commented on PR #3966:


15 months ago
#3

Before:
https://i0.wp.com/user-images.githubusercontent.com/11491369/216320537-5970d6e0-fe07-48f3-b501-559912d125d2.png

After:
https://i0.wp.com/user-images.githubusercontent.com/11491369/216320437-f69cd0f0-702d-4ee2-8e1f-0a86e147f771.png

#4 @kebbet
15 months ago

  • Keywords has-screenshots added

Thanks for milestoning @costdev!

PR and screenshot attached.

#5 @kebbet
15 months ago

  • Keywords needs-refresh added

So, here goes. Props to @costdev for helping out understanding whats going on.

There is two buttons that says Update Media in core in the file wp-admin/media.php. This file is not referenced in core anywhere. In a comment by @afercia 6 years ago it is referenced as the Old Edit Media screen.

Two themes have references to the file, but it is in their default.po file. (Search result)
More plugins have references to the file, but many references *.po and *.pot files. (Search result)

The screen is actually possible to access via links like this: /wp-admin/media.php?attachment_id=NNNN&action=edit where NNNN is the attachment ID.

The screen is broken, clicking the Insert into Post button leads to a white screen.

So, to match the help tab text what any user interface look like, I suggest to change the button texts to Update from Update Media.

A follow up ticket might need to be opened for disussing the faith of wp-admin/media.php.

Last edited 15 months ago by kebbet (previous) (diff)

@kebbet commented on PR #3966:


15 months ago
#6

See the ticket for context of the latest commit.

The screen after latest patch:
https://i0.wp.com/user-images.githubusercontent.com/11491369/216348359-f93cc632-e298-4566-a75f-87d1bb83db5d.png

#7 @kebbet
15 months ago

  • Keywords needs-refresh removed

#8 @audrasjb
15 months ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to reviewing

This change looks good to me 👍

#9 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55195:

Help/About: Update help tab texts to consistently describe button labels.

This changeset ensures help tab texts consistently refer to the related button labels.

Props kebbet, costdev.
Fixes #57608.

#12 @audrasjb
12 months ago

In 55647:

Media: Deprecate wp-admin/media.php.

The wp-admin/media.php file was introduced in [7262], then removed from the Media workflow in [21948].
This changeset finally deprecates it as it is not used anymore.

Follow-up to [7262], [21948].

Props kebbet, costdev, SergeyBiryukov, jrf, antpb, audrasjb.
Fixes #57612.
See #6181, #21391, #57608.

Note: See TracTickets for help on using tickets.