Help tab, says […] Update Media […], while button says Update

[kebbet]

Found while editing an attachment:

The help tab text says:
Remember to click Update Media to save metadata entered or changed.

The primary button on the screen says Update.

The string is found in both wp-admin/media.php and wp-admin/edit-form-advanced.php.
I suggest a change to just Update in both places.

[costdev]

Hi @kebbet, thanks for opening this ticket! I agree, let's make this consistent.

Milestoning for 6.2 as it's likely to be a very quick change.

https://core.trac.wordpress.org/ticket/57608

Before:

After:

[kebbet]

Thanks for milestoning @costdev!

PR and screenshot attached.

[kebbet]

So, here goes. Props to @costdev for helping out understanding whats going on.

There is two buttons that says Update Media in core in the file wp-admin/media.php. This file is not referenced in core anywhere. In a comment by @afercia 6 years ago it is referenced as the Old Edit Media screen.

Two themes have references to the file, but it is in their default.po file. (​Search result)
More plugins have references to the file, but many references *.po and *.pot files. (​Search result)

The screen is actually possible to access via links like this: /wp-admin/media.php?attachment_id=NNNN&action=edit where NNNN is the attachment ID.

The screen is broken, clicking the Insert into Post button leads to a white screen.

So, to match the help tab text what any user interface look like, I suggest to change the button texts to Update from Update Media.

A follow up ticket might need to be opened for disussing the faith of wp-admin/media.php.

See the ticket for context of the latest commit.

The screen after latest patch:

[audrasjb]

This change looks good to me 👍

[audrasjb]

In 55195:

Help/About: Update help tab texts to consistently describe button labels.

This changeset ensures help tab texts consistently refer to the related button labels.

Props kebbet, costdev.
Fixes #57608.

committed in https://core.trac.wordpress.org/changeset/55195

committed in https://core.trac.wordpress.org/changeset/55195

[audrasjb]

In 55647:

Media: Deprecate wp-admin/media.php.

The wp-admin/media.php file was introduced in [7262], then removed from the Media workflow in [21948].
This changeset finally deprecates it as it is not used anymore.

Follow-up to [7262], [21948].

Props kebbet, costdev, SergeyBiryukov, jrf, antpb, audrasjb.
Fixes #57612.
See #6181, #21391, #57608.