#57608 closed defect (bug) (fixed)
Help tab, says […] Update Media […], while button says Update
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Help/About | Keywords: | has-patch has-screenshots commit |
Focuses: | ui-copy | Cc: |
Description
Found while editing an attachment:
The help tab text says:
Remember to click Update Media to save metadata entered or changed.
The primary button on the screen says Update
.
The string is found in both wp-admin/media.php
and wp-admin/edit-form-advanced.php
.
I suggest a change to just Update
in both places.
Change History (12)
This ticket was mentioned in PR #3966 on WordPress/wordpress-develop by @kebbet.
2 years ago
#2
- Keywords has-patch added; needs-patch removed
#4
@
2 years ago
- Keywords has-screenshots added
Thanks for milestoning @costdev!
PR and screenshot attached.
#5
@
2 years ago
- Keywords needs-refresh added
So, here goes. Props to @costdev for helping out understanding whats going on.
There is two buttons that says Update Media
in core in the file wp-admin/media.php
. This file is not referenced in core anywhere. In a comment by @afercia 6 years ago it is referenced as the Old Edit Media
screen.
Two themes have references to the file, but it is in their default.po
file. (Search result)
More plugins have references to the file, but many references *.po
and *.pot
files. (Search result)
The screen is actually possible to access via links like this: /wp-admin/media.php?attachment_id=NNNN&action=edit
where NNNN
is the attachment ID.
The screen is broken, clicking the Insert into Post
button leads to a white screen.
So, to match the help tab text what any user interface look like, I suggest to change the button texts to Update
from Update Media
.
A follow up ticket might need to be opened for disussing the faith of wp-admin/media.php
.
#8
@
2 years ago
- Keywords commit added
- Owner set to audrasjb
- Status changed from new to reviewing
This change looks good to me 👍
@audrasjb commented on PR #3966:
2 years ago
#10
committed in https://core.trac.wordpress.org/changeset/55195
@audrasjb commented on PR #3966:
2 years ago
#11
committed in https://core.trac.wordpress.org/changeset/55195
Hi @kebbet, thanks for opening this ticket! I agree, let's make this consistent.
Milestoning for 6.2 as it's likely to be a very quick change.