PclZipUtilTranslateWinPath() fails when php_uname() function not available

[daymobrew]

In PclZip class (wp-admin/includes/class-pclzip.php) PclZipUtilTranslateWinPath() calls php_uname(). If that function is disabled then the call fails.

php_uname() is disabled on EasyWP host (part of Namecheap).
​https://www.namecheap.com/support/knowledgebase/article.aspx/9901/2279/easywp-list-of-php-functions-disabled-on-easywp-platform/

Core handles this by checking whether php_uname() exists (in wp-admin/includes/class-wp-debug.php).

Is it possible to get PclZip to do the same? I checked PclZip host site (​http://www.phpconcept.net) but there was no contact info there.

This error arose while using ​https://wordpress.org/plugins/simply-static/

[desrosj]

Hi @daymobrew,

Welcome to Trac! First, my apologies that this took so long to get a response.

I did a bit of digging, and ​found this repository on GitHub that appears to be where this library is maintained. Core is running version 2.8.2, but 2.8.3 is available upstream. Though ​none of the changes appear to be related to your specific issue, and there has been no effort to make the library PHP >= 8 compatible. So I think it's fine to consider this library "adopted" by WordPress.

I think adding a functions_exists() check is reasonable. However, I'm not too familiar with Windows, so I'm not sure what the consequences could be for scenarios where the logic within that if() statement should execute.

Some hosts disable php_uname().
To ensure detection of Windows continues, check PHP_OS.

@costdev and @desrosj,

Any news on this?

[SergeyBiryukov]

In 59506:

Filesystem API: Check PHP_OS_FAMILY instead of php_uname() in PclZip.

The php_uname() function can be disabled on some hosts, in which case the call fails.

The PHP_OS_FAMILY constant indicates the operating system family PHP was built for, and is available as of PHP 7.2.0.

Reference: ​PHP Manual: Predefined Constants: PHP_OS_FAMILY.

Follow-up to [6779], [57985], [58678], [58684].

Props daymobrew, costdev, desrosj.
Fixes #57711.

Thanks for the PR! Merged in r59506.