Make WordPress Core

#57827 closed defect (bug) (fixed)

Remove `wp-nux` CSS as dependency from `wp-edit-post` and `wp-editor`.

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Script Loader Keywords:
Focuses: performance Cc:

Description

The CSS for both wp-edit-post and wp-editor list the wp-nux CSS file as a dependency. This results in nux.css being loaded when using these packages.

Neither wp-edit-post or wp-editor use any of the styles included in nux.css so the dependency can be removed.

Related #57643.

A pull request exists for this. I'll see if I can get it to link to this ticket too.

Change History (5)

#1 follow-up: @flixos90
14 months ago

Thanks @peterwilsoncc, the change makes sense to me. Just wondering, is this really a bug? If it is, maybe we can still commit it for 6.2 Beta. But to me removing a dependency that's unused seems more like an enhancement, unless it was causing any actual bugs for the end user. In that case we could commit it once trunk opens for 6.3.

Last edited 14 months ago by flixos90 (previous) (diff)

#2 in reply to: ↑ 1 @peterwilsoncc
14 months ago

Replying to flixos90:

Thanks @peterwilsoncc, the change makes sense to me. Just wondering, is this really a bug? If it is, maybe we can still commit it for 6.2 Beta.

I think it's one of those items that falls neatly between bug and enhancement. I lean toward the former but left the ticket in review for the release squad to decide if it's the latter.

I'm happy with whatever milestone you decide.

#3 @peterwilsoncc
13 months ago

  • Milestone changed from Awaiting Review to 6.3

#4 @peterwilsoncc
13 months ago

  • Component changed from Editor to Script Loader

#5 @peterwilsoncc
13 months ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 55628:

Script Loader: Remove unused wp-nux CSS dependency.

Neither wp-edit-post nor wp-editor use the styles included in the wp-nux CSS file. This removes nux as a dependency from the registration of the two files.

Props flixos90, youknowriad, peterwilsoncc.
Fixes #57827.
See #57643.

Note: See TracTickets for help on using tickets.