WordPress.org
Get WordPress

Make WordPress Core

Opened 17 months ago

Last modified 16 months ago

#57899 new defect (bug)

Bad javascript in customize-controls.js for padding-top causes bugs

Reported by: akissz's profile akissz Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Customize Keywords: reporter-feedback needs-testing-info
Focuses: javascript, css Cc:

Description

The code for sections "Release header element if it is sticky." and "Reset position of the sticky header." is very bad old code and should be coded in a more modern way now. This code causes bugs in many situations and should either be eliminated all together and replaced with modern css only/instead or improved javascript to not include a forced css for padding-top.

Change History (3)

#1 @sabernhardt
17 months ago

  • Component changed from General to Customize
  • Focuses javascript css added

The ​Sticky header feature starts earlier, and it probably would involve editing more than the releaseStickyHeader and resetStickyHeader sections.

This ticket was mentioned in ​Slack in #core-test by juhise. ​View the logs.
16 months ago

#3 @oglekler
16 months ago

  • Keywords reporter-feedback needs-testing-info added

Hi @akissz,
can you please provide more information about the old code included in the implementation and how it can create bugs? It will help to nail the problem and solve it. Thank you!

Note: See TracTickets for help on using tickets.