WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#57994 closed defect (bug) (fixed)

Coding Standards fixes for WP 6.2.1

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.2.1 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch fixed-major
Focuses: coding-standards Cc:

Description

As part of the pre-release checks for 6.2, @davidbaumwald and I noticed some WPCS formatting issues that could be fixed by running composer format.

See the attached patch.

Follow-up to [55099], [55192], [55194], [55271].

Attachments (1)

57994.diff​ (3.5 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (6)

@SergeyBiryukov
3 years ago

This ticket was mentioned in ​Slack in #core by sergey. ​View the logs.
3 years ago

#2 @jrf
3 years ago

I fully support this patch. Could it already be committed to trunk for 6.3 ?

#3 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 55606:

Coding Standards: Apply various alignment corrections from composer format.

This fixes a few WPCS warnings along the lines of:

  • Array double arrow not aligned correctly
  • Equals sign not aligned with surrounding statements
  • Usage of ELSE IF is discouraged; use ELSEIF instead

Follow-up to [55099], [55192], [55194], [55271].

Props davidbaumwald, jrf, SergeyBiryukov.
Fixes #57994.

#4 @SergeyBiryukov
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 6.2.1 consideration.

#5 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 55636:

Coding Standards: Apply various alignment corrections from composer format.

This fixes a few WPCS warnings along the lines of:

  • Array double arrow not aligned correctly
  • Equals sign not aligned with surrounding statements
  • Usage of ELSE IF is discouraged; use ELSEIF instead

Follow-up to [55099], [55192], [55194], [55271].

Props davidbaumwald, jrf, SergeyBiryukov.
Merges [55606] to the 6.2 branch.
Fixes #57994.

Note: See TracTickets for help on using tickets.