Make WordPress Core

#58217 closed defect (bug) (fixed)

The URL defined "Text_Diff_Engine_native" is not working as expected.

Reported by: utsav72640's profile utsav72640 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.2
Component: External Libraries Keywords: has-patch changes-requested
Focuses: docs Cc:

Description

The URL defined "Text_Diff_Engine_native" is not working as expected.

Path : wp-includes/Text/Diff/Engine/native.php

I have attached a list of URLs that returned a 404 error.

http://www.perl.com/CPAN/authors/id/N/NE/NEDKONZ/Algorithm-Diff-1.06.zip
http://opensource.org/licenses/lgpl-license.php

Attachments (6)

nativecode.png (133.1 KB) - added by utsav72640 12 months ago.
wp-includes/Text/Diff/Engine/native.php
opensource404.png (113.5 KB) - added by utsav72640 12 months ago.
Algorithm404.png (52.2 KB) - added by utsav72640 12 months ago.
searching.png (147.1 KB) - added by utsav72640 12 months ago.
I have found a list of URLs that returned a 404 error.
58217.patch (4.6 KB) - added by jigar bhanushali 12 months ago.
I have replaced 404 URL to a new valid URL.
58217.2.patch (4.7 KB) - added by jigar bhanushali 12 months ago.

Download all attachments as: .zip

Change History (11)

@utsav72640
12 months ago

wp-includes/Text/Diff/Engine/native.php

@utsav72640
12 months ago

I have found a list of URLs that returned a 404 error.

@jigar bhanushali
12 months ago

I have replaced 404 URL to a new valid URL.

#1 @jigar bhanushali
12 months ago

  • Focuses docs added

@utsav72640 Thank you for the report

Due to the publication of a new licence version for the LGPL, I inspected those URLs and discovered that they all redirect to 404. I have added an attachment patch and updated it with a new URL.

Thanks

#2 @SergeyBiryukov
12 months ago

  • Keywords has-patch changes-requested added; dev-feedback removed
  • Milestone changed from Awaiting Review to 6.3

Hi there, thanks for the patch!

#3 @jigar bhanushali
12 months ago

@SergeyBiryukov I've applied your suggestion in the updated patch, please review it and do let me know if need any changes.

#4 @utsav72640
12 months ago

Thanks for the patch @jigar-bhanushali

#5 @SergeyBiryukov
12 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 55700:

External Libraries: Update license URL in Text_Diff library.

The former URL used to refer to LGPL 2.1 at the time, but does not redirect to its current location.

Includes updating the Algorithm::Diff Perl module URL.

Props jigar-bhanushali, utsav72640.
Fixes #58217.

Note: See TracTickets for help on using tickets.