Make WordPress Core

Opened 10 months ago

Last modified 5 weeks ago

#58370 new enhancement

Add 'Activate' button to View details modal

Reported by: afragen's profile afragen Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 6.3
Component: Plugins Keywords: needs-patch has-screenshots
Focuses: ui Cc:

Description

In discussions with @azaozz regarding the Plugin Dependencies feature, it was thought that a button in the View details modal would provide for a smoother UX. This way the user wouldn't need to go to a different page to activate an installed plugin.

Attachments (5)

activate_in_modal.png (1.6 MB) - added by afragen 10 months ago.
Modal with 'Activate' button
58370.diff (1.6 KB) - added by nihar007 10 months ago.
activate-button-in-plugin-view-details-popup.png (1.5 MB) - added by nihar007 10 months ago.
activate-button-in-plugin-view-details-popup.2.png (1.5 MB) - added by nihar007 10 months ago.
58370.1.diff (2.9 KB) - added by joedolson 8 months ago.
Partial patch

Change History (19)

@afragen
10 months ago

Modal with 'Activate' button

This ticket was mentioned in Slack in #core-upgrade-install by afragen. View the logs.


10 months ago

#2 @azaozz
10 months ago

  • Milestone changed from Awaiting Review to 6.3

Yes, thinking it will be a nice enhancement to be able to activate an already installed plugin from the "More Details" modal. Currently the user will have to go to either the plugin's "card" on the Add New screen or to the plugin's row in the list table to be able to activate.

#3 @costdev
10 months ago

Notes:

  1. Clicking "Install Now" in the modal will currently close it. This closing behaviour would likely need to be removed.
  2. Clicking "Install Now", then re-opening the modal shows that the button does not animate during installation. This would need to animate to provide feedback to the user once (1) is removed.
    • This is where the button currently used in the plugin card could be abstracted for use in the modal too. It has these variations for its initial state:
      • Install Now
      • Activate
      • Network Activate
      • Update Now
      • Cannot Update
      • Installed
      • Cannot Install
      • Cannot Activate
      • Active
    • By comparison, the current button in the modal has these initial state variations:
      • Install Now
      • Cannot Install
      • Install Update Now
      • Cannot Update
      • Newer version %s installed
      • Latest version installed
    • This would also need to account for an installation error notice, which currently shows at the bottom of the plugin card, but is placed in any div with the classname plugin-card-$slug.
Last edited 10 months ago by costdev (previous) (diff)

#4 @costdev
10 months ago

Pinging @flixos90 and @obenland who worked on Shiny Updates and may be able to help/work on this as it deals with using src/js/_enqueues/wp/updates.js for the modal button.

#5 @obenland
10 months ago

It's been 7 years, so I'm not sure I still have much of a head start to anyone diving in fresh 🙂
Happy to help with reviews or anything else needed here, though.

@nihar007
10 months ago

#6 @afragen
10 months ago

@nihar007 I believe the idea would be to only display an active 'Activate' button if the plugin was installed.

We are still likely waiting on #design feedback for this.

Your current patch has some logic issues as an uninstalled plugin cannot be activated.

This ticket was mentioned in Slack in #core by oglekler. View the logs.


9 months ago

@joedolson
8 months ago

Partial patch

#8 follow-up: @joedolson
8 months ago

I started on this, and I'm just sharing the work in progress, since I won't have time to work on it further any time soon. Patch disables closing the modal on update/install & adds the activate button using existing logic, but needs work to run update/install inline within the modal & add notifications within the modal.

#9 in reply to: ↑ 8 @azaozz
8 months ago

  • Milestone changed from 6.3 to 6.4

Replying to joedolson:

I started on this, and I'm just sharing the work in progress, since I won't have time to work on it further any time soon.

Thanks! Patch looks good so far.

Unfortunately I couldn't get to this either, moving to 6.4.

This ticket was mentioned in Slack in #core by oglekler. View the logs.


7 months ago

This ticket was mentioned in Slack in #core by oglekler. View the logs.


6 months ago

#12 @oglekler
6 months ago

  • Milestone changed from 6.4 to 6.5

There is only partial patch and no time before Beta 1 to finish and test it, so, I am moving this ticket into the 6.5 milestone.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


5 weeks ago

#14 @audrasjb
5 weeks ago

  • Milestone changed from 6.5 to Future Release

From today's bug scrub:
As this is an enhancement and since we’re still waiting for a final patch, let’s move it to Future Release.
Happy to review and move it back to milestone 6.5 if a complete patch is proposed during the alpha cycle.

Last edited 5 weeks ago by audrasjb (previous) (diff)
Note: See TracTickets for help on using tickets.