WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#58481 closed defect (bug) (fixed)

Mark `apply_filters()` third parameter as optional

Reported by: audrasjb Owned by: audrasjb
Priority: normal Milestone: 6.3
Component: General Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: docs

Description

The $args parameter of apply_filters() is optional. We should update the related Docblock description accordingly so the parameter is not indicated as required on DevHub.

See ​https://developer.wordpress.org/reference/functions/apply_filters/

Props @gilles66 for pointing this out in a DevHub comment.

Attachments (2)

Capture d’écran 2023-06-06 à 17.12.01.png​ (97.8 KB ) - added by audrasjb 3 years ago.
apply-filter-fix.diff​ (712 bytes ) - added by gaeldenysiak 3 years ago.

Download all attachments as: .zip

Change History (6)

@audrasjb
3 years ago

@gaeldenysiak
3 years ago

#1 @gaeldenysiak
3 years ago

Hi, my name is Gael. I've been working on WordPress for a while and I'm excited to offer my first contribution, which I hope will be the first of many :) Have a great day, community!

#2 @audrasjb
3 years ago

  • Focuses docs added
  • Milestone Awaiting Review → 6.3

#3 @audrasjb
3 years ago

  • Keywords has-patch commit added

Hey @gaeldenysiak welcome to Trac and thanks for the patch!

Looks good to ship!

#4 @audrasjb
3 years ago

  • Resolution → fixed
  • Status assigned → closed

In 55893:

Docs: Mark apply_filters() third parameter $args as optional.

The $args parameter of apply_filters() is optional. This changeset updates the related Docblock description accordingly so the parameter is not marked as
required on DevHub.

Props gaeldenysiak, audrasjb, gilles66.
Fixes #58481.
See #57840.

Note: See TracTickets for help on using tickets.