#58524 closed task (blessed) (fixed)
Rest API: add /revisions endpoint for global styles
Reported by: | ramonopoly | Owned by: | isabel_brison |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | 6.3 |
Component: | REST API | Keywords: | has-patch has-unit-tests gutenberg-merge add-to-field-guide |
Focuses: | Cc: |
Description
The following Global Revisions UI was added to Gutenberg in https://github.com/WordPress/gutenberg/pull/50089
To support this, an endpoint (/wp/v2/global-styles/revisions
) that returns revisions for the global styles custom post was added and updated in:
https://github.com/WordPress/gutenberg/pull/49974
https://github.com/WordPress/gutenberg/pull/50234
We need to synchronize the PHP changes that add the endpoint to returns revisions for the global styles custom post.
Change History (16)
This ticket was mentioned in PR #4606 on WordPress/wordpress-develop by @ramonopoly.
15 months ago
#1
- Keywords has-patch has-unit-tests added
#2
@
15 months ago
- Keywords gutenberg-merge added
- Type changed from defect (bug) to enhancement
- Version set to trunk
@ramonopoly commented on PR #4606:
15 months ago
#4
Thank @TimothyBJacobs @spacedmonkey and @peterwilsoncc for helping me make this patch better.
I think I've addressed all of the feedback, (except for the context test) at least I think so. Please let me know where it can be improved.
@ramonopoly commented on PR #4606:
15 months ago
#5
A couple of nitpics. This is nearly there. Is there a committer / owner for this change?
I appreciate the continued feedback 🙇
I'll get those changes in today and will liaise with @tellthemachines to get it committed
This ticket was mentioned in Slack in #core by chaion07. View the logs.
15 months ago
#7
@
15 months ago
- Type changed from enhancement to task (blessed)
Thanks @ramonopoly for reporting this. We discussed this ticket during a recent bug-scrub session. Based on the feedback we are updating the ticket with the following changes:
- Converting it into a Task
- Keeping in the 6.3 milestone
Cheers!
Props to @audrasjb
#8
@
15 months ago
- Owner set to isabel_brison
- Resolution set to fixed
- Status changed from new to closed
In 56082:
This ticket was mentioned in PR #4750 on WordPress/wordpress-develop by @ramonopoly.
15 months ago
#10
Some missed formatting and also implementing feedback from https://github.com/WordPress/wordpress-develop/pull/4606#pullrequestreview-1500696132 (adding missing @covers
to tests and swapping order of @ticket
and @covers
order)
Trac ticket: https://core.trac.wordpress.org/ticket/58524
@ramonopoly commented on PR #4606:
15 months ago
#11
The unit tests could do with @covers.
Thanks! PR for that here: https://github.com/WordPress/wordpress-develop/pull/4750
The following Global Revisions UI was added to Gutenberg in:
To support this, an endpoint (/wp/v2/global-styles/revisions) that returns revisions for the global styles custom post was added and updated in:
This PR adds the endpoint to Core and adds tests.
Trac ticket: https://core.trac.wordpress.org/ticket/58524
## Testing
To test the endpoint in the site editor, fire up this branch and head over to the site editor.
In your browser's console, switch to the network tab and run the following :
npm run test:php -- --filter WP_REST_Global_Styles_Revisions_Controller_Test