Make WordPress Core

#58526 closed defect (bug) (fixed)

Twenty Fifteen: Button Letter Case is Not Working

Reported by: thakordarshil's profile thakordarshil Owned by:
Milestone: 6.3 Priority: normal
Severity: normal Version: 6.2.2
Component: Bundled Theme Keywords: has-patch has-screenshots
Focuses: css Cc:

Description

In Twenty Fifteen theme when we add button & try to add letter case in frontend & Backend (ex: Uppercase , Capitalize or lower case)

Steps to Reproduce the Issue :

  • Activate Twenty Fifteen theme.
  • Add Button in Any Page
  • Add Letter Case in Button Block

Video Link: https://drive.google.com/file/d/1H3PLl5QFPFVdWCsU1v8UIwT70GjchiPB/view

Attachments (10)

58526.diff (1000 bytes) - added by thakordarshil 12 months ago.
Patch Added
Before-patch-backend.png (91.5 KB) - added by pateljaymin 12 months ago.
Before Patch - Backend
after-pactch-backend.png (91.4 KB) - added by pateljaymin 12 months ago.
After Patch - Backend
Before-patch-frontend.png (70.2 KB) - added by pateljaymin 12 months ago.
Before Patch - Frontend
after-pactch-frontend.png (81.0 KB) - added by pateljaymin 12 months ago.
After Patch - Frontend
58526.1.diff (5.8 KB) - added by sabernhardt 11 months ago.
supporting Letter Case control in Twenty Fourteen, Twenty Fifteen, Twenty Sixteen and Twenty Twenty
Before-patch-backend.2.png (31.5 KB) - added by panchalhimani711 11 months ago.
Before Patch-Backend
After-patch-backend.png (33.7 KB) - added by panchalhimani711 11 months ago.
After Patch-Backend
Before-patch-frontend.2.png (36.3 KB) - added by panchalhimani711 11 months ago.
Before Patch-Frontend
After-patch-frontend.png (28.2 KB) - added by panchalhimani711 11 months ago.
After Patch-Frontend

Download all attachments as: .zip

Change History (22)

@thakordarshil
12 months ago

Patch Added

@pateljaymin
12 months ago

Before Patch - Backend

@pateljaymin
12 months ago

After Patch - Backend

@pateljaymin
12 months ago

Before Patch - Frontend

@pateljaymin
12 months ago

After Patch - Frontend

#1 @pateljaymin
12 months ago

Hi @thakordarshil

I have tested patch with wordpress 6.2.2 & Patch is working fine

#2 @sabernhardt
11 months ago

58526.diff could fix blocks where the user chose something other than uppercase, but it also changes every other Button block created with this theme.

The Letter Case control does not work in any theme that assigns a text-transform property to the .wp-block-button__link element, including:

  • Twenty Fourteen
  • Twenty Fifteen
  • Twenty Sixteen
  • Twenty Twenty

The default Button block styles probably could add the following to ensure support in any theme:

.wp-block-buttons[style*="text-transform"] .wp-block-button__link,
.wp-block-button[style*="text-transform"] .wp-block-button__link {
	text-transform: inherit;
}

Both selectors are necessary. The text-transform style is added to .wp-block-buttons when the Buttons block only has one Button block; multiple Button blocks in the same Buttons block get their own style attribute on the .wp-block-button container.

In case all themes that use uppercase should support the user control individually, I can add that to a patch for the bundled themes.

@sabernhardt
11 months ago

supporting Letter Case control in Twenty Fourteen, Twenty Fifteen, Twenty Sixteen and Twenty Twenty

@panchalhimani711
11 months ago

Before Patch-Backend

@panchalhimani711
11 months ago

After Patch-Backend

@panchalhimani711
11 months ago

Before Patch-Frontend

@panchalhimani711
11 months ago

After Patch-Frontend

#3 @panchalhimani711
11 months ago

  • Keywords has-screenshots added

@sabernhardt

I have tested this patch: https://core.trac.wordpress.org/attachment/ticket/58526/58526.1.diff
for twentyfifteen theme & it's working fine.

Thanks.

#4 @mukesh27
11 months ago

  • Keywords needs-testing added

Thank you, @thakordarshil, for the ticket.

Hey, @panchalhimani711, could you please review all the themes mentioned by @sabernhardt and provide a report?

The themes to check are:

  • Twenty Fourteen
  • Twenty Fifteen
  • Twenty Sixteen
  • Twenty Twenty

#5 @panchalhimani711
11 months ago

@mukesh27

Test Report for - https://core.trac.wordpress.org/attachment/ticket/58526/58526.1.diff Patch.

Theme - Twenty Fourteen

Backend :
=======
Before Patch Backend : https://prnt.sc/_BcvUA_2fdUa
After Patch Backend : https://prnt.sc/4l2ew1jAYOEF

Frontend :
=======
Before Patch Frontend : https://prnt.sc/sj_lyve3VBdi
After Patch Frontend : https://prnt.sc/caFy7_r0QmWC

Theme - Twenty Fifteen

Backend :
=======
Before Patch Backend: https://prnt.sc/qpSN3cpsdKCN
After Patch Backend : https://prnt.sc/B_erZQ6mMvY8

Frontend :
=======
Before Patch Frontend : https://prnt.sc/bvUBTE_zP2Rm
After Patch Frontend : https://prnt.sc/68EjnkLapsxl

Theme - Twenty Sixteen

Backend :
========
Before Patch Backend : https://prnt.sc/PJdafJDoVrzI
After Patch Backend : https://prnt.sc/mI8AdmjXI7mH

Frontend :
========
Before Patch Frontend : https://prnt.sc/BncoQgCapBHR
After Patch Frontend : https://prnt.sc/3wd_UZby68JM

Theme - Twenty Twenty

Backend :
=======
Before Patch Backend : https://prnt.sc/RCTYc8xKM3LE
After Patch Backend : https://prnt.sc/_jlZFP_M2b5p

Frontend :
========
Before Patch Frontend : https://prnt.sc/621EF2GHrL1Q
After Patch Frontend : https://prnt.sc/HoI2UxjhWpQ7

https://core.trac.wordpress.org/attachment/ticket/58526/58526.1.diff
Patch is Working fine in all mentioned theme

Thanks.

#6 @sabernhardt
11 months ago

  • Milestone changed from Awaiting Review to 6.3

#7 @mukesh27
11 months ago

  • Keywords commit added; needs-testing removed

Thanks for the report @panchalhimani711

@sabernhardt already assign it in milestone. The patch solve issue for all the themes.

commit added keyword. Ping @audrasjb for review.

#8 @audrasjb
11 months ago

In 55997:

Twenty Fourteen: Fix Letter Case implementation.

This changeset fixes Letter Case control implementation on the Button block, on both front-end and in the Editor.

Props thakordarshil, pateljaymin, sabernhardt, panchalhimani711, mukesh27.
See #58526.

#9 @audrasjb
11 months ago

In 55998:

Twenty Fifteen: Fix Letter Case implementation.

This changeset fixes Letter Case control implementation on the Button block, on both front-end and in the Editor.

Props thakordarshil, pateljaymin, sabernhardt, panchalhimani711, mukesh27.
See #58526.

#10 @audrasjb
11 months ago

In 55999:

Twenty Sixteen: Fix Letter Case implementation.

This changeset fixes Letter Case control implementation on the Button block, on both front-end and in the Editor.

Props thakordarshil, pateljaymin, sabernhardt, panchalhimani711, mukesh27.
See #58526.

#11 @audrasjb
11 months ago

In 56000:

Twenty Twenty: Fix Letter Case implementation.

This changeset fixes Letter Case control implementation on the Button block, on both front-end and in the Editor.

Props thakordarshil, pateljaymin, sabernhardt, panchalhimani711, mukesh27.
See #58526.

#12 @audrasjb
11 months ago

  • Keywords commit removed
  • Resolution set to fixed
  • Status changed from new to closed

Thanks everyone. I committed these fixes independently so they can be referenced one by one on theme changelogs (or even reverted if needed).

Closing as fixed.

Note: See TracTickets for help on using tickets.