Make WordPress Core

Opened 2 years ago

Closed 17 months ago

#58547 closed defect (bug) (fixed)

Twenty Seventeen: Calendar block header cells should be centered

Reported by: nkeller15's profile nkeller15 Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: trivial Version: 6.2.2
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

The th elements in the Calendar block are not centered like the rest of the text in the Calendar which looks odd.

Attachments (5)

SCR-20230615-mhev.png (161.5 KB) - added by nkeller15 2 years ago.
Screenshot
58547.patch (564 bytes) - added by nkeller15 2 years ago.
Added new code in the blocks.css file to fix this
2017-calendar-front-before.png (402.7 KB) - added by sabernhardt 2 years ago.
header cells are aligned left only when Calendar block is inside post content area
2017-calendar-front-with-patch.png (402.9 KB) - added by sabernhardt 2 years ago.
the patch corrects the alignment on the front
58547.diff (1.2 KB) - added by shailu25 17 months ago.
Patch Added

Download all attachments as: .zip

Change History (12)

@nkeller15
2 years ago

Screenshot

@nkeller15
2 years ago

Added new code in the blocks.css file to fix this

@sabernhardt
2 years ago

header cells are aligned left only when Calendar block is inside post content area

@sabernhardt
2 years ago

the patch corrects the alignment on the front

#1 @sabernhardt
2 years ago

  • Keywords 2nd-opinion added
  • Severity changed from normal to trivial
  • Summary changed from Twenty Seventeen - Calendar Widget <th> alignment should be centered to Twenty Seventeen: Calendar block header cells should be centered

The Calendar block is not as likely to be used inside the post content area as within one of the widget areas in a "classic" theme such as Twenty Seventeen. The header cells already are centered where the block is expected.

That said, the patch works on the front end. If the styles are changed in blocks.css, then editor-blocks.css probably should have the same.

#2 @karmatosed
19 months ago

  • Keywords changes-requested added; 2nd-opinion removed

I would like to see this patch at least refreshed also to have it work for the editor before further consideration. I think there might be a case to add it if it doesn't break anything but benefits in the particular case, that said it needs to be both front and editor applied. Thank you everyone for your collaboration so far.

#3 @karmatosed
17 months ago

  • Milestone changed from Awaiting Review to Future Release

#4 @karmatosed
17 months ago

  • Keywords needs-refresh added

@shailu25
17 months ago

Patch Added

#5 @shailu25
17 months ago

  • Keywords changes-requested needs-refresh removed

Added Patch as per mentioned in above comment (Changes are added in block.css & editor-blocks.css)

Version 0, edited 17 months ago by shailu25 (next)

#6 @karmatosed
17 months ago

  • Keywords commit added
  • Milestone changed from Future Release to 6.6
  • Owner set to karmatosed
  • Status changed from new to assigned

Assigning to myself as looking to take this through to commit if everything works out. Thank you everyone.

#7 @karmatosed
17 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58461:

Twenty Seventeen: Resolves calendar block header cells not centering.

The calendar header block cells were not centered. This resolves that both in front and back.

Props nkeller15, sabernhardt, shailu25.
Fixes #58547.

Note: See TracTickets for help on using tickets.