#58548 closed enhancement (fixed)
Update layout classnames and specificity
Reported by: | isabel_brison | Owned by: | isabel_brison |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | 6.3 |
Component: | Editor | Keywords: | gutenberg-merge has-patch has-unit-tests |
Focuses: | Cc: |
Description
This ticket tracks the changes to src/wp-includes/block-supports/layout.php
, src/wp-includes/class-wp-theme-json.php
and src/wp-includes/theme.json
from the following Gutenberg PRs:
https://github.com/WordPress/gutenberg/pull/47858
https://github.com/WordPress/gutenberg/pull/47952
Because they touch the same parts of the same files and are conceptually close I think it makes sense to bring them in together.
Change History (5)
This ticket was mentioned in PR #4623 on WordPress/wordpress-develop by @isabel_brison.
15 months ago
#1
- Keywords has-patch has-unit-tests added
#2
@
15 months ago
Hi
I am sorry if this is a stupid question or remark, but in this PR, we are updating
theme.json > layout definitions > spacingStyles,
and in https://core.trac.wordpress.org/ticket/58550 we are moving the layout definitions to block-supports/layout.php:
https://github.com/WordPress/wordpress-develop/pull/4624/files#diff-859f1673f11bdb7ef6b2b9d1ab516b06ce464f8d065d129beacd94cd23888cc0R22
Trac ticket: https://core.trac.wordpress.org/ticket/58548
This PR backports the PHP changes from https://github.com/WordPress/gutenberg/pull/47858 and
https://github.com/WordPress/gutenberg/pull/47952.
To test the changes, build PR branch locally. and make sure a block theme such as Twenty Twenty Three is enabled. Until the npm packages are updated, these changes will only be testable on the front end.
wp-block-group-is-layout-constrained
class, in addition to the previously existing classes.